Skip to content

Commit 599f89c

Browse files
CopilotnikhilNava
andcommitted
Improve documentation for empty method implementations
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
1 parent 4e850bf commit 599f89c

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

  • libraries
    • microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core
    • microsoft-agents-a365-observability-extensions-agentframework/microsoft_agents_a365/observability/extensions/agentframework

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/execute_tool_scope.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,10 @@ def __init__(
120120
def record_response(self, response: str) -> None:
121121
"""Records response information for telemetry tracking.
122122
123+
Note: This method is intentionally a no-op as GEN_AI_EVENT_CONTENT was removed.
124+
The method is kept for interface compatibility.
125+
123126
Args:
124127
response: The response to record
125128
"""
126-
pass # GEN_AI_EVENT_CONTENT removed
129+
pass

libraries/microsoft-agents-a365-observability-extensions-agentframework/microsoft_agents_a365/observability/extensions/agentframework/span_processor.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55

66

77
class AgentFrameworkSpanProcessor(SpanProcessor):
8-
"""
9-
SpanProcessor for Agent Framework.
8+
"""SpanProcessor for Agent Framework.
9+
10+
Note: The span processing logic was removed as GEN_AI_EVENT_CONTENT is no longer used.
11+
This processor is kept for interface compatibility.
1012
"""
1113

1214
TOOL_CALL_RESULT_TAG = "gen_ai.tool.call.result"
@@ -16,7 +18,9 @@ def __init__(self, service_name: str | None = None):
1618
super().__init__()
1719

1820
def on_start(self, span, parent_context):
21+
"""Called when a span starts. Intentionally a no-op."""
1922
pass
2023

2124
def on_end(self, span):
25+
"""Called when a span ends. Intentionally a no-op."""
2226
pass

0 commit comments

Comments
 (0)