[CI] Build and Release Workflow Docker Missing Dependencies

[Kevindua26]

Current Behavior

Missing Docker Dependency in build-and-release.yml
Currently, both jobs run independently and in parallel. The docker job doesn't wait for the build job to complete.

Risk

• When the build jobs fail, the docker job still start and run.
• The Docker build process inside the Docker image might fail if the binary wasn't properly built.
• This creates a broken Docker image being pushed to the registry

Desired Behavior

Create explicit dependency telling github action, don't start the docker until build job succeed.

Implementation

Add need keyword which tells github action to create job dependency of docker job.

[lekaf974]

@Kevindua26 I don't see any dependency requirements between build and docker since the binary is built inside the Dockerfile but not sure the build step is necessary.

[Kevindua26]

Totally agree with you @lekaf974 .
The main thing I found is if the build job got fails, the docker still starts seamlessly, but docker image build process might fail if the binary wasn't properly built during build job.

[lekaf974]

Totally agree with you @lekaf974 . The main thing I found is if the build job got fails, the docker still starts seamlessly, but docker image build process might fail if the binary wasn't properly built during build job.

That's my point since we are rebuilding the binary in the Dockerfile, it looks the build step is not required

[Kevindua26]

That's my point since we are rebuilding the binary in the Dockerfile, it looks the build step is not required

Okay, so am I supposed to remove the build job from the workflow?
Or we can build the binary in the build job only, eliminating the need to rebuild it in the docker job by adding a needs keyword in the docker job, just like the current PR.

[lekaf974]

If you remove the build step in the Dockerfile it needs to be updated to have the binary in the docker image. I'd say check in other meshery repos how it is done