Skip to content

Commit 5b15754

Browse files
committed
Add support for firewall rules version and fingerprint
1 parent 42ca199 commit 5b15754

File tree

6 files changed

+22
-6
lines changed

6 files changed

+22
-6
lines changed

test/fixtures/networking_firewalls_123.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
"outbound":[],
99
"outbound_policy":"DROP",
1010
"inbound":[],
11-
"inbound_policy":"DROP"
11+
"inbound_policy":"DROP",
12+
"version":2,
13+
"fingerprint":"4ef67a29"
1214
},
1315
"tags":[]
1416
}

test/fixtures/networking_firewalls_123_rules.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,7 @@
22
"inbound": [],
33
"inbound_policy": "DROP",
44
"outbound": [],
5-
"outbound_policy": "DROP"
5+
"outbound_policy": "DROP",
6+
"version": 2,
7+
"fingerprint": "4ef67a29"
68
}

test/fixtures/networking_firewalls_templates.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@
4040
"protocol": "TCP"
4141
}
4242
],
43-
"inbound_policy": "DROP"
43+
"inbound_policy": "DROP",
44+
"version": 2,
45+
"fingerprint": "4ef67a29"
4446
}
4547
},
4648
{
@@ -83,7 +85,9 @@
8385
"protocol": "TCP"
8486
}
8587
],
86-
"inbound_policy": "DROP"
88+
"inbound_policy": "DROP",
89+
"version": 2,
90+
"fingerprint": "4ef67a29"
8791
}
8892
}
8993
],

test/fixtures/networking_firewalls_templates_public.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
"protocol": "TCP"
3939
}
4040
],
41-
"inbound_policy": "DROP"
41+
"inbound_policy": "DROP",
42+
"version": 2,
43+
"fingerprint": "4ef67a29"
4244
}
4345
}

test/fixtures/networking_firewalls_templates_vpc.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
"protocol": "TCP"
3939
}
4040
],
41-
"inbound_policy": "DROP"
41+
"inbound_policy": "DROP",
42+
"version": 2,
43+
"fingerprint": "4ef67a29"
4244
}
4345
}

test/unit/objects/firewall_test.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ def test_get_rules(self):
2020
self.assertEqual(rules.inbound_policy, "DROP")
2121
self.assertEqual(len(rules.outbound), 0)
2222
self.assertEqual(rules.outbound_policy, "DROP")
23+
self.assertEqual(rules.version, 2)
24+
self.assertEqual(rules.fingerprint, "4ef67a29")
2325

2426
def test_update_rules(self):
2527
"""
@@ -125,6 +127,8 @@ class FirewallTemplatesTest(ClientBaseCase):
125127
def assert_rules(rules: MappedObject):
126128
assert rules.outbound_policy == "DROP"
127129
assert len(rules.outbound) == 1
130+
assert rules.version == 2
131+
assert rules.fingerprint == "4ef67a29"
128132

129133
assert rules.inbound_policy == "DROP"
130134
assert len(rules.inbound) == 1

0 commit comments

Comments
 (0)