-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Mobile navigation menu contains invalid nesting #7484
Copy link
Copy link
Open
Labels
framework/gatsbyGatsby relatedGatsby relatedframework/reactReact relatedReact relatedgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededkind/bugSomething isn't workingSomething isn't workinglanguage/htmlIssues or pull requests that use HTMLIssues or pull requests that use HTMLlanguage/javascriptIssues or pull requests that use Javascript or ReactIssues or pull requests that use Javascript or React
Metadata
Metadata
Assignees
Labels
framework/gatsbyGatsby relatedGatsby relatedframework/reactReact relatedReact relatedgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededkind/bugSomething isn't workingSomething isn't workinglanguage/htmlIssues or pull requests that use HTMLIssues or pull requests that use HTMLlanguage/javascriptIssues or pull requests that use Javascript or ReactIssues or pull requests that use Javascript or React
Description
The mobile navigation menu contains invalid nesting that violates HTML5 specifications. An unordered list (
<ul>) can only contain<li>,<script>, or<template>elements as direct children.There are multiple
<a>tags placed as direct children of the<ul>tags rather than being wrapped inside an<li>.Location: Found in the dropdown menus (https://github.com/layer5io/layer5/blob/master/src/sections/General/Navigation/index.js#L344-L345). For example:
Expected Behavior
Avoid negatively impacting accessibility (screen readers will struggle to count list items) and can cause cross-browser layout inconsistencies.
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
masterbranch.