Skip to content

frontend: ResourceTable Name Search story is broken #5082

@sniok

Description

@sniok

NameSearch story is supposed to demonstrate that the table will search using the search value but it doesn't actually do that.

Image

Screenshot of this story with an empty search input

To Reproduce

  1. npm run storybook in frontend/
  2. Open 'Name Search' story
  3. Observe empty input

Are you able to fix this issue?

Maybe later but if anyone else wants to take this feel free to do so

Additional Context

This is a logic error in the story, it sets the search to the redux store, which ResourceTable doesn't use
ResourceTable also accepts defaultGlobalFilter prop that is forwards to the Table component but that also doesn't work after changes made in #3354, global filter is read from the query param

Metadata

Metadata

Assignees

Labels

dxfrontendIssues related to the frontendkind/bugCategorizes issue or PR as related to a bug.testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions