You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using Cluster dropdown in the Cluster Settings page, settings values are incredibly broken, sometimes appearing, sometimes disappearing and overriding cluster settings with values from previously selected cluster
To Reproduce
Steps to reproduce the bug:
Have at least two clusters in headlamp
Go to Cluster Settings page
Go to cluster1 and set a setting like allowed namespace
Switch to cluster2
Switch back to cluster1
Repeat steps 4,5
Observe that the allowed namespace value sometimes is missing from cluster1, sometimes appears in cluster2
Observe the localStorage values in the DevTools when you switch between clusters using the dropdown. Cluster Settings values in local storage are updated when just switching between clusters. This shouldn't cause any writes or updates!
Demo
Video where I change allowed namespace in one cluster and then just toggle between two clusters
cluster-settings-broken.mp4
Are you able to fix this issue?
yeah
notes
This is caused by duplicated state, lack of single source of truth, broken rules of hooks (we should REALLY enable those eslint rules) and ad-hoc syncing with localStorage. The page really needs a refactor.
When using
Clusterdropdown in the Cluster Settings page, settings values are incredibly broken, sometimes appearing, sometimes disappearing and overriding cluster settings with values from previously selected clusterTo Reproduce
Steps to reproduce the bug:
allowed namespaceDemo
Video where I change allowed namespace in one cluster and then just toggle between two clusters
cluster-settings-broken.mp4
Are you able to fix this issue?
yeah
notes
This is caused by duplicated state, lack of single source of truth, broken rules of hooks (we should REALLY enable those eslint rules) and ad-hoc syncing with localStorage. The page really needs a refactor.