Solang parser incompatibility from introducing Soroban storage types

[salaheldinsoliman]

This PR: #1664 introduces three new keywords to Solang's parser, causing incompatibilities with Solidity parser. Thanks @smoelius for raising this up 👍

[seanyoung]

We could resolve this by making the lexer aware of the target, and lex them appropriately.

[sridhar-panigrahi]

Hi @salaheldinsoliman, I'd like to work on this issue. Based on
@seanyoung's suggestion, my approach would be to make the lexer
target-aware so that persistent, temporary, and instance are only lexed as
keywords when the Soroban target is selected, and treated as regular
identifiers otherwise.

Could you assign this to me? Happy to discuss the approach before opening
a PR.

[salaheldinsoliman]

Hi @sridhar-panigrahi , thanks for your interest, I will assign the issue to you and we can discuss the approach in the PR itself :)

[sridhar-panigrahi]

@salaheldinsoliman , Thanks for assigning me the issue , I've started working on it ☺️

[sridhar-panigrahi]

Hi @salaheldinsoliman, I've opened a PR for this: #1852. The fix makes the lexer target-aware — persistent, temporary, and instance are only treated as keywords when targeting Soroban, and fall back to plain identifiers for all other targets. Happy to hear any feedback!

[Sukuna0007Abhi]

Hi @salaheldinsoliman can I work on this as the previous pr is closed and no work happened lately, could you pls assign me

[sridhar-panigrahi]

Hey @salaheldinsoliman, I've opened a new PR #1861 for this. The previous one had a cargo fmt issue which caused the CI failure — fixed that and it should be good to go now. Let me know if you have any feedback!