fix(test): troubleshoot sendSigned

Author: Hack.bg R&D

README.md

@@ -259,7 +259,8 @@ The tests run on an automatically managed ephemeral Elements localnet in `elemen
 * `bad-txns-in-ne-out` when inputs/outputs do seem to add up
   * -> `VerifyAmounts` in Elements `confidential_validation.cpp`  -> oh my...
   * Use `rpc.listunspent(0, 9999999, [sender])` to get a valid UTXO
-* `min-relay-fee` -> ?
+  * Make sure not to mess up the decimals. **Pass satoshis as String and BigInt, Bitcoins as Number**
+* `min-relay-fee` -> ? the fee output is misconfigured
 
 ## Acknowledgments, References, Attribution
 

src/sdk.ts

@@ -1,4 +1,4 @@
-import type Bitcoin    from '../../Bitcoin/Bitcoin.ts';
+import type Bitcoin    from '../../Bitcoin/index.ts';
 import Fn              from '../../../library/Fn.ts';
 import { Log }         from '../../../library/Log.ts';
 import { Num, Base16 } from '../../../library/Number.ts';
@@ -65,7 +65,7 @@ export async function Wasm ({
 }
 
 /** Load [Wasm] with default settings and create a [WasmKeypair]. */
-export async function Keypair (secret: Uint8Array): Promise<Keypair> {
+export async function Keypair (secret: Uint8Array) {
   const { keypair } = await Wasm();
   return keypair(secret)
 }
@@ -143,7 +143,9 @@ export async function Program (source: string, {
 }
 
 /** Format a `{ type, value }` pair as used to pass `param` and `witness` values. */
-export function Arg (type: string, value?: unknown) { return { type, value } }
+export function Arg (type: string, value?: unknown) {
+  return { type, value }
+}
 
 /** SimplicityHL program argument constructors.
   *

src/test.ts

@@ -1,10 +1,9 @@
 #!/usr/bin/env -S deno run --allow-read --allow-env --allow-run --allow-write=/tmp/fadroma --allow-import=cdn.skypack.dev:443,deno.land:443 --allow-net=127.0.0.1:8941,liquidtestnet.com:443,blockstream.info:443
 import { deepStrictEqual as equal, rejects, throws, ok } from 'node:assert';
 import { Base16, Fn, Test, Run, sleep } from '../../../library/index.ts';
-import { pubECDSA } from 'npm:@scure/btc-signer/utils.js';
-import Btc, { BtcRpc, Esplora, LiquidTestnet, ElementsRegtest } from '../../Bitcoin/index.ts';
+import Btc, { BtcRpc, LiquidTestnet, ElementsRegtest } from '../../Bitcoin/index.ts';
 import { SendFromWallet, AssertBalance } from '../../Bitcoin/test.ts';
-import { Signer, Keypair, Program, Wasm, Arg, Args } from './sdk.ts';
+import { Signer, Program, Wasm, Arg, Args } from './sdk.ts';
 const { is, has } = Test;
 const { CreateWallet, Rescan } = BtcRpc;
 const { INITIAL_COINS, BITCOIN } = ElementsRegtest;
@@ -48,7 +47,7 @@ export function TestOnLocalnet () {
   const BALANCE_INITIAL = { [ElementsRegtest.ASSETS.REISSUE]: 1, bitcoin: Number(INITIAL_COINS / BITCOIN) };
   // Tests that run on temporary localnet:
   return Test('elementsregtest',
-    () => ElementsRegtest({ debugs: true, debugexclude: ['libevent'] }),
+    () => ElementsRegtest({ debugs: false, debugexclude: ['libevent'] }),
     Run.Verbose(true), // Pipe the localnet's output to stderr
     CreateWallet('test-simf', AssertBalance(BALANCE_EMPTY)),
     Rescan(AssertBalance(BALANCE_INITIAL)),
@@ -107,8 +106,6 @@ export function TestOnLocalnet () {
 interface TestSend extends Btc {
   /** Chain-specific asset IDs. */
   ASSETS:      { [key: string]: unknown },
-  /** Input transaction. */
-  tx:          unknown
   /** To provide funds on testnet. */
   callFaucet?: Fn.Returns<Fn.Async<{ txid: string }>>,
   /** Creates a P2WPKH address configured for the given network. */
@@ -119,28 +116,59 @@ interface TestSend extends Btc {
   recipient:   string
 }
 
-function TestSend (signer1 = null, signer2 = null, amount = 3000n, fee = 12000n) {
+function TestSend (amount = 3000n, fee = 12000n) {
   const keypair1 = keypair(new Uint8Array(Array(32).fill(8)));
   const keypair2 = keypair(new Uint8Array(Array(32).fill(9)));
-  return Fn.Name('Test sendSigned', testSend);
+  return Fn.Name(`Test sendSigned ${amount} for ${fee}`, testSend);
   async function testSend ({ debug = console.debug, ...context }: TestSend) {
-    const { rpc, rest, esplora, callFaucet, tx: inputTx, ASSETS, P2WPKH } = context;
-    const sender    = P2WPKH(keypair1.publicKey()).address;
+    const { rpc, rest, esplora, callFaucet, ASSETS, P2WPKH } = context;
+    const sender = P2WPKH(keypair1.publicKey()).address;
     const recipient = P2WPKH(keypair2.publicKey()).address;
     debug(`Send ${amount} from ${sender} to ${recipient} at ${fee}`);
-    const unspent   = await rpc.listunspent(0, 9999999, [sender]); // TODO filter
-    const utxo      = unspent[0]; // { asset, txid, vout, value, address }
+    const utxo = await findUtxo(sender);
     debug('Input:', utxo);
-    const options   = { sender, recipient, asset: utxo.asset, amount, fee, utxos: [utxo] };
-    const signed    = sendSigned(keypair1, options);
-    debug('Signed:', signed);
-    try {
-      const id = await rpc!.sendrawtransaction(signed.hex);
-      const tx = await rest!.tx(id);
-      await rpc!.rescanblockchain();
-    } catch (e) {
-      await sleep(1000);
-      throw e
+    const options = { recipient, sender, utxos: [utxo], asset: utxo.asset, amount, fee };
+    const signed = sendSigned(keypair1, options);
+    const tx = await sendSignedTransaction(signed.hex);
+    console.log({tx});
+
+    async function sendSignedTransaction (hex: string) {
+      debug('Broadcasting signed transaction:', signed);
+      if (rpc && rest) {
+        const id = await rpc!.sendrawtransaction(hex);
+        await rpc!.rescanblockchain();
+        const tx = await rest!.tx(id);
+        return tx;
+      } else if (esplora) {
+        const id = await esplora.postTx(hex);
+        while (true) {
+          const mempool = await esplora.getMempoolTxids().then(JSON.parse);
+          if (mempool.includes(id)) {
+            debug('TX still in mempool:', id);
+            await sleep(1000);
+          } else {
+            return esplora.getTxInfo(id);
+          }
+        }
+      } else {
+        throw new Error('need { rpc, rest } or { esplora } to broadcast signed transaction');
+      }
+    }
+
+    async function findUtxo (address: string): { asset, txid, vout, amount, address } {
+      if (rpc) {
+        const unspent = await rpc.listunspent(0, 9999999, [sender]); // TODO filter
+        if (!unspent[0]) throw new Error(`no UTXOs for ${sender}`);
+        const { txid, vout, amount, asset } = unspent[0];
+        return { asset, txid, vout, address, amount };
+      } else if (esplora) {
+        const unspent = await esplora.getAddressUtxos(sender);
+        if (!unspent[0]) throw new Error(`no UTXOs for ${sender}`)
+        const { txid, vout, value, asset } = unspent[0];
+        return { asset, txid, vout, address, amount: BigInt(value) };
+      } else {
+        throw new Error('need { rpc } or { esplora } to find unspent output');
+      }
     }
   }
 }