more coderabbit suggestions

Author: gotcha

ipdb/__main__.py

@@ -13,9 +13,8 @@
 __version__ = "0.13.14.dev0"
 
 from IPython import get_ipython
-from IPython.core.application import ProfileDir
 from IPython.core.debugger import BdbQuit_excepthook
-from IPython.core.profiledir import ProfileDirError
+from IPython.core.profiledir import ProfileDir, ProfileDirError
 from IPython.paths import get_ipython_dir
 from IPython.terminal.ipapp import TerminalIPythonApp
 from IPython.terminal.embed import InteractiveShellEmbed
@@ -33,15 +32,50 @@ def _get_debugger_cls(ipython_profile="default"):
         # Build a terminal app in order to force ipython to load the
         # configuration
         ipython_dir = get_ipython_dir()
+        profile_dir = None
+        
+        # First, try to find the requested profile
         try:
             profile_dir = ProfileDir.find_profile_dir_by_name(
                 ipython_dir=ipython_dir,
                 name=ipython_profile,
             )
-        except ProfileDirError:  # fallback to default-profile
-            profile_dir = ProfileDir.find_profile_dir_by_name(
-                ipython_dir=ipython_dir,
-            )
+        except ProfileDirError:
+            # Profile doesn't exist, try to create it
+            try:
+                profile_dir = ProfileDir.create_profile_dir_by_name(
+                    ipython_dir=ipython_dir,
+                    name=ipython_profile,
+                )
+            except (ProfileDirError, Exception):
+                # Creation failed, fallback to default profile
+                profile_dir = None
+        
+        # If we still don't have a profile_dir, try the default profile
+        if profile_dir is None:
+            try:
+                # Try to find default profile
+                profile_dir = ProfileDir.find_profile_dir_by_name(
+                    ipython_dir=ipython_dir,
+                    name='default',
+                )
+            except ProfileDirError:
+                # Default doesn't exist either, create it
+                try:
+                    profile_dir = ProfileDir.create_profile_dir_by_name(
+                        ipython_dir=ipython_dir,
+                        name='default',
+                    )
+                except (ProfileDirError, Exception):
+                    # Last resort: create profile without name
+                    profile_dir = ProfileDir.create_profile_dir_by_name(
+                        ipython_dir=ipython_dir,
+                    )
+        
+        # Ensure we have a profile_dir before creating TerminalIPythonApp
+        if profile_dir is None:
+            raise RuntimeError("Unable to create or find any IPython profile directory")
+        
         ipapp = TerminalIPythonApp(profile_dir=profile_dir)
 
         # Avoid output (banner, prints)

tests/test_config.py

@@ -405,12 +405,12 @@ def test_missing_profile_setup(self):
         os.unlink(self.setup_filename)
         write_lines_to_file(
             self.pyproject_filename,
-            ""
+            []
         )
 
         with ModifiedEnvironment(IPDB_CONFIG=None, HOME=self.tmpd):
             profile_name = get_ipython_profile_from_config()
-            assert profile_name == "default"
+            self.assertEqual(profile_name, "default")
 
     def test_default_profile_setup(self):
         """
@@ -431,7 +431,7 @@ def test_default_profile_setup(self):
 
         with ModifiedEnvironment(IPDB_CONFIG=None, HOME=self.tmpd):
             profile_name = get_ipython_profile_from_config()
-            assert profile_name == "default"
+            self.assertEqual(profile_name, "default")
 
     def test_non_default_profile_setup(self):
         """
@@ -451,4 +451,4 @@ def test_non_default_profile_setup(self):
 
         with ModifiedEnvironment(IPDB_CONFIG=None, HOME=self.tmpd):
             profile_name = get_ipython_profile_from_config()
-            assert profile_name == "foo"
+            self.assertEqual(profile_name, "foo")