Skip to content

Commit 47a7998

Browse files
committed
Revert recent test skips and dependency overrides
This reverts the following commits because the issues were fixed externally: - 4671b3f: fix(apigeeregistry): skip failing quickstart test - ae52412: fix(storage-control): type conflict between @sinonjs/fake-timers and @types/sinonjs__fake-timers - 1ee8974: fix(area120-tables): skip failing quickstart test
1 parent 4671b3f commit 47a7998

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

packages/google-area120-tables/samples/test/quickstart.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe('Quickstart', () => {
3434
projectId = await client.getProjectId();
3535
});
3636

37-
it.skip('should run quickstart', async () => {
37+
it('should run quickstart', async () => {
3838
const stdout = execSync(`node ./quickstart.js ${projectId}`);
3939
assert.match(stdout, /\[[^\]]*\]/);
4040
});

packages/google-cloud-apigeeregistry/samples/test/quickstart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ describe('Quickstart', () => {
4141
projectId = await client.getProjectId();
4242
});
4343

44-
it.skip('should run quickstart', async () => {
44+
it('should run quickstart', async () => {
4545
assert.throws(() => {
4646
execSync(`node ./quickstart.js projects/${projectId}/locations/global`, {
4747
cwd,

packages/google-storage-control/package.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,5 @@
6868
},
6969
"engines": {
7070
"node": ">=18"
71-
},
72-
"overrides": {
73-
"@sinonjs/fake-timers": "15.2.1"
74-
},
75-
"pnpm": {
76-
"overrides": {
77-
"@sinonjs/fake-timers": "15.2.1"
78-
}
7971
}
8072
}

0 commit comments

Comments
 (0)