Merge branch 'master' into docs/include-api-version

Author: alexandear

.custom-gcl.yml

@@ -4,6 +4,8 @@ plugins:
     path: ./tools/extraneousnew
   - module: "github.com/google/go-github/v84/tools/fmtpercentv"
     path: ./tools/fmtpercentv
+  - module: "github.com/google/go-github/v84/tools/redundantptr"
+    path: ./tools/redundantptr
   - module: "github.com/google/go-github/v84/tools/sliceofpointers"
     path: ./tools/sliceofpointers
   - module: "github.com/google/go-github/v84/tools/structfield"

.golangci.yml

@@ -27,6 +27,7 @@ linters:
     - nolintlint
     - paralleltest
     - perfsprint
+    - redundantptr
     - revive
     - sliceofpointers
     - staticcheck
@@ -193,6 +194,10 @@ linters:
         type: module
         description: Reports usage of %d or %s in format strings.
         original-url: github.com/google/go-github/v84/tools/fmtpercentv
+      redundantptr:
+        type: module
+        description: Reports github.Ptr(x) calls that can be replaced with &x.
+        original-url: github.com/google/go-github/v84/tools/redundantptr
       sliceofpointers:
         type: module
         description: Reports usage of []*string and slices of structs without pointers.

example/commitpr/main.go

@@ -105,7 +105,7 @@ func getTree(ref *github.Reference) (tree *github.Tree, err error) {
 		if err != nil {
 			return nil, err
 		}
-		entries = append(entries, &github.TreeEntry{Path: github.Ptr(file), Type: github.Ptr("blob"), Content: github.Ptr(string(content)), Mode: github.Ptr("100644")})
+		entries = append(entries, &github.TreeEntry{Path: &file, Type: github.Ptr("blob"), Content: github.Ptr(string(content)), Mode: github.Ptr("100644")})
 	}
 
 	tree, _, err = client.Git.CreateTree(ctx, *sourceOwner, *sourceRepo, *ref.Object.SHA, entries)

github/actions_hosted_runners_test.go

@@ -111,7 +111,7 @@ func TestActionsService_ListHostedRunners(t *testing.T) {
 						Length:  31,
 					},
 				},
-				LastActiveOn: Ptr(lastActiveOn),
+				LastActiveOn: &lastActiveOn,
 			},
 			{
 				ID:            Ptr(int64(7)),
@@ -132,7 +132,7 @@ func TestActionsService_ListHostedRunners(t *testing.T) {
 				MaximumRunners:  Ptr(int64(20)),
 				PublicIPEnabled: Ptr(false),
 				PublicIPs:       []*HostedRunnerPublicIP{},
-				LastActiveOn:    Ptr(lastActiveOn),
+				LastActiveOn:    &lastActiveOn,
 			},
 		},
 	}
@@ -236,7 +236,7 @@ func TestActionsService_CreateHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -652,7 +652,7 @@ func TestActionsService_GetHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -748,7 +748,7 @@ func TestActionsService_UpdateHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -837,7 +837,7 @@ func TestActionsService_DeleteHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {

github/actions_runner_groups_test.go

@@ -513,7 +513,7 @@ func TestActionsService_ListRunnerGroupHostedRunners(t *testing.T) {
 						Length:  31,
 					},
 				},
-				LastActiveOn: Ptr(lastActiveOn),
+				LastActiveOn: &lastActiveOn,
 			},
 			{
 				ID:            Ptr(int64(7)),
@@ -534,7 +534,7 @@ func TestActionsService_ListRunnerGroupHostedRunners(t *testing.T) {
 				MaximumRunners:  Ptr(int64(20)),
 				PublicIPEnabled: Ptr(false),
 				PublicIPs:       []*HostedRunnerPublicIP{},
-				LastActiveOn:    Ptr(lastActiveOn),
+				LastActiveOn:    &lastActiveOn,
 			},
 		},
 	}

github/apps.go

@@ -431,7 +431,7 @@ func (s *AppsService) CreateInstallationTokenListRepos(ctx context.Context, id i
 //meta:operation POST /repos/{owner}/{repo}/content_references/{content_reference_id}/attachments
 func (s *AppsService) CreateAttachment(ctx context.Context, contentReferenceID int64, title, body string) (*Attachment, *Response, error) {
 	u := fmt.Sprintf("content_references/%v/attachments", contentReferenceID)
-	payload := &Attachment{Title: Ptr(title), Body: Ptr(body)}
+	payload := &Attachment{Title: &title, Body: &body}
 	req, err := s.client.NewRequest("POST", u, payload)
 	if err != nil {
 		return nil, nil, err

github/copilot.go

@@ -491,6 +491,10 @@ func (s *CopilotService) GetSeatDetails(ctx context.Context, org, user string) (
 
 // GetEnterpriseMetrics gets Copilot usage metrics for an enterprise.
 //
+// Deprecated: This endpoint was closed down on April 2, 2026 for github.com.
+// It may still be available for GitHub Enterprise Server. Use GetEnterpriseDailyMetricsReport
+// or GetEnterpriseMetricsReport instead.
+//
 // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/copilot/copilot-metrics?apiVersion=2022-11-28#get-copilot-metrics-for-an-enterprise
 //
 //meta:operation GET /enterprises/{enterprise}/copilot/metrics
@@ -517,6 +521,10 @@ func (s *CopilotService) GetEnterpriseMetrics(ctx context.Context, enterprise st
 
 // GetEnterpriseTeamMetrics gets Copilot usage metrics for an enterprise team.
 //
+// Deprecated: This endpoint was closed down on April 2, 2026 for github.com.
+// It may still be available for GitHub Enterprise Server. Use GetEnterpriseDailyMetricsReport
+// or GetEnterpriseMetricsReport instead.
+//
 // GitHub API docs: https://docs.github.com/enterprise-cloud@latest/rest/copilot/copilot-metrics?apiVersion=2022-11-28#get-copilot-metrics-for-an-enterprise-team
 //
 //meta:operation GET /enterprises/{enterprise}/team/{team_slug}/copilot/metrics
@@ -543,6 +551,10 @@ func (s *CopilotService) GetEnterpriseTeamMetrics(ctx context.Context, enterpris
 
 // GetOrganizationMetrics gets Copilot usage metrics for an organization.
 //
+// Deprecated: This endpoint was closed down on April 2, 2026 for github.com.
+// It may still be available for GitHub Enterprise Server. Use GetOrganizationDailyMetricsReport
+// or GetOrganizationMetricsReport instead.
+//
 // GitHub API docs: https://docs.github.com/rest/copilot/copilot-metrics?apiVersion=2022-11-28#get-copilot-metrics-for-an-organization
 //
 //meta:operation GET /orgs/{org}/copilot/metrics
@@ -569,6 +581,10 @@ func (s *CopilotService) GetOrganizationMetrics(ctx context.Context, org string,
 
 // GetOrganizationTeamMetrics gets Copilot usage metrics for an organization team.
 //
+// Deprecated: This endpoint was closed down on April 2, 2026 for github.com.
+// It may still be available for GitHub Enterprise Server. Use GetOrganizationDailyMetricsReport
+// or GetOrganizationMetricsReport instead.
+//
 // GitHub API docs: https://docs.github.com/rest/copilot/copilot-metrics?apiVersion=2022-11-28#get-copilot-metrics-for-a-team
 //
 //meta:operation GET /orgs/{org}/team/{team_slug}/copilot/metrics

github/enterprise_actions_hosted_runners_test.go

@@ -111,7 +111,7 @@ func TestEnterpriseService_ListHostedRunners(t *testing.T) {
 						Length:  31,
 					},
 				},
-				LastActiveOn: Ptr(lastActiveOn),
+				LastActiveOn: &lastActiveOn,
 			},
 			{
 				ID:            Ptr(int64(7)),
@@ -132,7 +132,7 @@ func TestEnterpriseService_ListHostedRunners(t *testing.T) {
 				MaximumRunners:  Ptr(int64(20)),
 				PublicIPEnabled: Ptr(false),
 				PublicIPs:       []*HostedRunnerPublicIP{},
-				LastActiveOn:    Ptr(lastActiveOn),
+				LastActiveOn:    &lastActiveOn,
 			},
 		},
 	}
@@ -235,7 +235,7 @@ func TestEnterpriseService_CreateHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -650,7 +650,7 @@ func TestEnterpriseService_GetHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -747,7 +747,7 @@ func TestEnterpriseService_UpdateHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {
@@ -836,7 +836,7 @@ func TestEnterpriseService_DeleteHostedRunner(t *testing.T) {
 				Length:  31,
 			},
 		},
-		LastActiveOn: Ptr(lastActiveOn),
+		LastActiveOn: &lastActiveOn,
 	}
 
 	if !cmp.Equal(hostedRunner, want) {

github/git_commits_test.go

@@ -235,7 +235,7 @@ func TestGitService_CreateSignedCommit(t *testing.T) {
 		Tree:    &Tree{SHA: Ptr("t")},
 		Parents: []*Commit{{SHA: Ptr("p")}},
 		Verification: &SignatureVerification{
-			Signature: Ptr(signature),
+			Signature: &signature,
 		},
 	}
 
@@ -249,7 +249,7 @@ func TestGitService_CreateSignedCommit(t *testing.T) {
 			Message:   input.Message,
 			Tree:      Ptr("t"),
 			Parents:   []string{"p"},
-			Signature: Ptr(signature),
+			Signature: &signature,
 		}
 		if !cmp.Equal(v, want) {
 			t.Errorf("Request body = %+v, want %+v", v, want)
@@ -336,7 +336,7 @@ Commit Message.`
 		fmt.Fprintf(w, `{"sha":"%v"}`, sha)
 	})
 	ctx := t.Context()
-	wantCommit := &Commit{SHA: Ptr(sha)}
+	wantCommit := &Commit{SHA: &sha}
 	opts := CreateCommitOptions{Signer: mockSigner(t, signature, nil, wantMessage)}
 	commit, _, err := client.Git.CreateCommit(ctx, "o", "r", input, &opts)
 	assertNilError(t, err)