fix test

Author: meiji163

doc/hooks.md

@@ -81,7 +81,7 @@ The following variables are available on all hooks:
 
 The following variable are available on particular hooks:
 
-- `GH_OST_INSTANT_DDL` is only available in `gh-ost-on-success`. The value is true if instant DDL was successful.
+- `GH_OST_INSTANT_DDL` is only available in `gh-ost-on-success`. The value is `true` if instant DDL was successful, and `false` if it was not.
 - `GH_OST_COMMAND` is only available in `gh-ost-on-interactive-command`
 - `GH_OST_STATUS` is only available in `gh-ost-on-status`
 - `GH_OST_LAST_BATCH_COPY_ERROR` is only available in `gh-ost-on-batch-copy-retry`

go/logic/hooks_test.go

@@ -105,6 +105,8 @@ func TestHooksExecutorExecuteHooks(t *testing.T) {
 				require.Equal(t, 50.0, progress)
 			case "GH_OST_TABLE_NAME":
 				require.Equal(t, migrationContext.OriginalTableName, split[1])
+			case "GH_OST_INSTANT_DDL":
+				require.Equal(t, "false", split[1])
 			case "TEST":
 				require.Equal(t, t.Name(), split[1])
 			}

go/logic/migrator.go

@@ -478,7 +478,6 @@ func (this *Migrator) Migrate() (err error) {
 	if this.migrationContext.AttemptInstantDDL {
 		if this.migrationContext.Noop {
 			this.migrationContext.Log.Debugf("Noop operation; not really attempting instant DDL")
-			return this.hooksExecutor.onSuccess(true)
 		} else {
 			this.migrationContext.Log.Infof("Attempting to execute alter with ALGORITHM=INSTANT")
 			if err := this.applier.AttemptInstantDDL(); err == nil {