Modernize library: target net8.0/net10.0, source-gen regex, records, immutability (#131)

* Modernize library: target net8.0/net10.0, source-gen regex, records, immutability

- Drop netstandard2.0, target net8.0 and net10.0 LTS
- Convert all Regex fields to [GeneratedRegex] on partial methods
- Convert BusinessDay and DateTimeRange to record types
- Convert AgeSpan to readonly record struct
- Embrace immutability: IReadOnlyList, FrozenDictionary, get/init properties
- Enable nullable reference types and implicit usings
- Use String./Int32./Char. for static method calls per project convention
- Use ReadOnlySpan<char> in TimeUnit and Helper for zero-alloc parsing
- Restore all contextual comments stripped during modernization
- Preserve public API: restore protected virtual Validate on BusinessWeek
- Upgrade test project to xUnit v3 with Microsoft Testing Platform

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix CI build: suppress test-only nullable warnings and entry point conflict

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix CI: register GitHubActionsTestLogger MTP extension and address PR feedback

- Explicitly register GitHubActionsTestLogger as a TestingPlatformBuilderHook
  to fix --report-github Unknown option error in CI (the packages build
  props do not flow correctly with single TargetFramework projects)
- Remove redundant RegexOptions.Compiled from all [GeneratedRegex] attributes
  (source generator already compiles at build time)
- Use pattern matching null checks (is null) instead of == null
- Wrap List<T> assignments with .AsReadOnly() for true immutability on
  IReadOnlyList<T> properties in ComparisonFormatParser and TwoPartFormatParser

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: niemyjski

AGENTS.md

@@ -16,7 +16,7 @@ Exceptionless.DateTimeExtensions provides date/time utilities for .NET applicati
 - **DateTimeOffset Extensions** - Mirror of DateTime extensions for DateTimeOffset with offset-aware operations
 - **TimeSpan Extensions** - Human-readable formatting (`ToWords`), year/month extraction, rounding, `AgeSpan` struct
 
-Design principles: **parse flexibility**, **timezone correctness**, **comprehensive edge case handling**, **netstandard2.0 compatibility**.
+Design principles: **parse flexibility**, **timezone correctness**, **comprehensive edge case handling**, **modern .NET features** (targeting net8.0/net10.0).
 
 ## Quick Start
 
@@ -111,14 +111,24 @@ The library uses a **priority-ordered parser chain** for `DateTimeRange.Parse()`
 ### Code Quality
 
 - Write complete, runnable code—no placeholders, TODOs, or `// existing code...` comments
-- Use modern C# features compatible with **netstandard2.0**: be mindful of API availability
+- Use modern C# features available in **net8.0/net10.0**
+- **Nullable reference types** are enabled—annotate nullability correctly, don't suppress warnings without justification
+- **ImplicitUsings** are enabled—don't add `using System;`, `using System.Collections.Generic;`, etc.
 - Follow SOLID, DRY principles; remove unused code and parameters
 - Clear, descriptive naming; prefer explicit over clever
-- Use `ConfigureAwait(false)` in library code (not in tests)
+
+### Modern .NET Idioms
+
+- **Source-generated regexes**: Use `[GeneratedRegex]` on `partial` methods instead of `new Regex(...)` or `RegexOptions.Compiled`
+- **Record types**: Use `record` for immutable data types; use `readonly record struct` for small value types
+- **Frozen collections**: Use `FrozenDictionary` / `FrozenSet` for immutable lookup collections initialized once
+- **Guard APIs**: Use `ArgumentNullException.ThrowIfNull()`, `ArgumentException.ThrowIfNullOrEmpty()`, `ArgumentOutOfRangeException.ThrowIfGreaterThan()` etc. instead of manual null/range checks
+- **Range/Index syntax**: Prefer `[..^N]`, `[start..end]` over `Substring` calls
+- **Pattern matching**: Use `is`, `switch` expressions, and property patterns where they improve clarity
 
 ### Parsing & Date Math Patterns
 
-- **Regex-based parsing**: Part parsers expose a `Regex` property; format parsers use regex internally
+- **Source-generated regex parsing**: Part parsers expose regex via `[GeneratedRegex]` partial methods; format parsers use source-generated regex internally
 - **Priority ordering**: Lower `[Priority]` values run first—put more specific/common parsers earlier
 - **Timezone preservation**: When parsing dates with explicit timezones (`Z`, `+05:00`), always preserve the original offset
 - **Upper/lower limit rounding**: `/d` rounds to start of day for lower limits, end of day for upper limits
@@ -143,8 +153,9 @@ The library uses a **priority-ordered parser chain** for `DateTimeRange.Parse()`
 ### Performance Considerations
 
 - **Avoid allocations in hot paths**: Parsing methods are called frequently; minimize string allocations
-- **Compiled regex**: Use `RegexOptions.Compiled` for frequently-used patterns
-- **Span-based parsing**: Where compatible with netstandard2.0, prefer span-based approaches
+- **Source-generated regex**: Use `[GeneratedRegex]` for all regex patterns—generates optimized code at compile time, avoiding runtime compilation overhead
+- **Frozen collections**: Use `FrozenDictionary` / `FrozenSet` for lookup tables that are initialized once and read many times
+- **Span-based parsing**: Prefer `ReadOnlySpan<char>` and span-based approaches for parsing hot paths
 - **Profile before optimizing**: Don't guess—measure
 - **Cache parser instances**: Parsers are discovered once via reflection and reused
 
@@ -202,7 +213,7 @@ Before marking work complete, verify:
 
 ### Error Handling
 
-- **Validate inputs**: Check for null, empty strings, invalid ranges at method entry
+- **Validate inputs**: Use `ArgumentNullException.ThrowIfNull()`, `ArgumentException.ThrowIfNullOrEmpty()`, and `ArgumentOutOfRangeException.ThrowIfGreaterThan()` etc. at method entry
 - **Fail fast**: Throw exceptions immediately for invalid arguments (don't propagate bad data)
 - **Meaningful messages**: Include parameter names and expected values in exception messages
 - **TryParse pattern**: Always provide a `TryParse` alternative that returns `bool` instead of throwing
@@ -220,7 +231,7 @@ Tests are not just validation—they're **executable documentation** and **desig
 
 ### Framework
 
-- **xUnit** as the primary testing framework
+- **xUnit v3** with **Microsoft Testing Platform** as the test runner
 - **Foundatio.Xunit** provides `TestWithLoggingBase` for test output logging
 - Follow [Microsoft unit testing best practices](https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-best-practices)
 

build/common.props

@@ -1,7 +1,9 @@
 <Project>
 
   <PropertyGroup>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>net8.0;net10.0</TargetFrameworks>
+    <Nullable>enable</Nullable>
+    <ImplicitUsings>enable</ImplicitUsings>
     <Product>Exceptionless DateTime Extensions</Product>
     <Description>DateTimeRange and various DateTime and TimeSpan extension methods.</Description>
     <PackageProjectUrl>https://github.com/exceptionless/Exceptionless.DateTimeExtensions</PackageProjectUrl>
@@ -12,7 +14,7 @@
 
     <Copyright>Copyright © $([System.DateTime]::Now.ToString(yyyy)) Exceptionless.  All rights reserved.</Copyright>
     <Authors>Exceptionless</Authors>
-    <NoWarn>$(NoWarn);CS1591;NU1701</NoWarn>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>
     <WarningsAsErrors>true</WarningsAsErrors>
     <LangVersion>latest</LangVersion>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>

src/Exceptionless.DateTimeExtensions/BusinessDay.cs

@@ -1,64 +1,54 @@
-using System;
 using System.Diagnostics;
 
 namespace Exceptionless.DateTimeExtensions;
 
 /// <summary>
-/// A class defining a business day.
+/// A record defining a business day.
 /// </summary>
 [DebuggerDisplay("DayOfWeek={DayOfWeek}, StartTime={StartTime}, EndTime={EndTime}")]
-public class BusinessDay
+public record BusinessDay
 {
     /// <summary>
-    /// Initializes a new instance of the <see cref="BusinessDay"/> class.
+    /// Initializes a new instance of the <see cref="BusinessDay"/> record with default 9am–5pm hours.
     /// </summary>
     /// <param name="dayOfWeek">The day of week this business day represents.</param>
-    public BusinessDay(DayOfWeek dayOfWeek)
-    {
-        StartTime = TimeSpan.FromHours(9); // 9am
-        EndTime = TimeSpan.FromHours(17); // 5pm
-        DayOfWeek = dayOfWeek;
-    }
+    public BusinessDay(DayOfWeek dayOfWeek) : this(dayOfWeek, TimeSpan.FromHours(9) /* 9am */, TimeSpan.FromHours(17) /* 5pm */) { }
 
     /// <summary>
-    /// Initializes a new instance of the <see cref="BusinessDay"/> class.
+    /// Initializes a new instance of the <see cref="BusinessDay"/> record.
     /// </summary>
     /// <param name="dayOfWeek">The day of week this business day represents.</param>
     /// <param name="startTime">The start time of the business day.</param>
     /// <param name="endTime">The end time of the business day.</param>
     public BusinessDay(DayOfWeek dayOfWeek, TimeSpan startTime, TimeSpan endTime)
     {
-        if (startTime.TotalDays >= 1)
-            throw new ArgumentOutOfRangeException(nameof(startTime), startTime, "The startTime argument must be less then one day.");
-
-        if (endTime.TotalDays > 1)
-            throw new ArgumentOutOfRangeException(nameof(endTime), endTime, "The endTime argument must be less then one day.");
-
+        ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual(startTime.TotalDays, 1.0, nameof(startTime));
+        ArgumentOutOfRangeException.ThrowIfGreaterThan(endTime.TotalDays, 1.0, nameof(endTime));
         if (endTime <= startTime)
-            throw new ArgumentOutOfRangeException(nameof(endTime), endTime, "The endTime argument must be greater then startTime.");
+            throw new ArgumentOutOfRangeException(nameof(endTime), endTime, "The endTime argument must be greater than startTime.");
 
         DayOfWeek = dayOfWeek;
         StartTime = startTime;
         EndTime = endTime;
     }
 
     /// <summary>
-    /// Gets the day of week this business day represents..
+    /// Gets the day of week this business day represents.
     /// </summary>
     /// <value>The day of week.</value>
-    public DayOfWeek DayOfWeek { get; private set; }
+    public DayOfWeek DayOfWeek { get; init; }
 
     /// <summary>
     /// Gets the start time of the business day.
     /// </summary>
     /// <value>The start time of the business day.</value>
-    public TimeSpan StartTime { get; private set; }
+    public TimeSpan StartTime { get; init; }
 
     /// <summary>
     /// Gets the end time of the business day.
     /// </summary>
     /// <value>The end time of the business day.</value>
-    public TimeSpan EndTime { get; private set; }
+    public TimeSpan EndTime { get; init; }
 
     /// <summary>
     /// Determines whether the specified date falls in the business day.
@@ -67,17 +57,6 @@ public BusinessDay(DayOfWeek dayOfWeek, TimeSpan startTime, TimeSpan endTime)
     /// <returns>
     /// 	<c>true</c> if the specified date falls in the business day; otherwise, <c>false</c>.
     /// </returns>
-    public bool IsBusinessDay(DateTime date)
-    {
-        if (date.DayOfWeek != DayOfWeek)
-            return false;
-
-        if (date.TimeOfDay < StartTime)
-            return false;
-
-        if (date.TimeOfDay > EndTime)
-            return false;
-
-        return true;
-    }
+    public bool IsBusinessDay(DateTime date) =>
+        date.DayOfWeek == DayOfWeek && date.TimeOfDay >= StartTime && date.TimeOfDay <= EndTime;
 }