Skip to content

docs: clean up data modeling docs and move cubes/views diagram#10685

Merged
keydunov merged 1 commit intomasterfrom
docs-data-modeling
Apr 14, 2026
Merged

docs: clean up data modeling docs and move cubes/views diagram#10685
keydunov merged 1 commit intomasterfrom
docs-data-modeling

Conversation

@keydunov
Copy link
Copy Markdown
Member

  • Remove stale docs-mintlify/data-modeling/ folder (duplicated content)
  • Move cubes/views diagram to top of Getting Started page
  • Remove OLAP terminology reference from Concepts page
  • Add introductory sentence listing key concepts on Concepts page

Made-with: Cursor

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

- Remove stale docs-mintlify/data-modeling/ folder (duplicated content)
- Move cubes/views diagram to top of Getting Started page
- Remove OLAP terminology reference from Concepts page
- Add introductory sentence listing key concepts on Concepts page

Made-with: Cursor
@keydunov keydunov merged commit 34a78f4 into master Apr 14, 2026
9 checks passed
@keydunov keydunov deleted the docs-data-modeling branch April 14, 2026 15:55
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 14, 2026

Claude finished @keydunov's task in 1m 33s —— View job


Code Review: docs cleanup and diagram relocation

  • Gather context and review PR diff
  • Review deleted files
  • Review modified files
  • Check for broken references
  • Provide final review feedback

This is a clean, well-scoped documentation PR. Here's my review:

Deleted files — docs-mintlify/data-modeling/ (stale folder)

The two deleted files (concepts.mdx and overview.mdx) under docs-mintlify/data-modeling/ were simplified duplicates of the canonical docs at docs-mintlify/docs/data-modeling/. Removing them is the right call — they weren't referenced in mint.json navigation and would have drifted further from the canonical versions over time. No broken references detected from this deletion.

Modified: docs-mintlify/docs/data-modeling/concepts/index.mdx

Changes look good:

  • Replaced the OLAP terminology header/reference with a concise introductory sentence listing key concepts with anchor links — more approachable for newcomers.
  • Moved the cubes/views diagram from the Views section to the top of the page, giving it better visibility.
  • Cleaned up the [wiki-olap] reference link (line 835) — no remaining references to it in this file.

Modified: docs-mintlify/docs/data-modeling/overview.mdx

Changes look good:

  • Added the cubes/views diagram at the top of the Getting Started page, right after the introductory paragraph — good placement for orientation.

Minor observations (non-blocking)

  1. Duplicate diagram on two pages: The same diagram (cdfe8858-f01d-4c25-af32-26502db62f1c) now appears on both the Getting Started page (overview.mdx) and the Concepts page (concepts/index.mdx). This seems intentional — both pages serve as entry points for different audiences — but worth confirming this is desired since users navigating sequentially will see it twice.

  2. Old diagram still referenced elsewhere: The previous cubes/views diagram (bfc3e04a-b690-40bc-a6f8-14a9175fb4fd) that was removed from the Concepts page is still used in two getting-started tutorial files:

    • docs-mintlify/docs/getting-started/cloud/create-data-model.mdx
    • docs-mintlify/docs/getting-started/databricks/create-data-model.mdx

    If the new diagram is meant to replace the old one across the docs, these files may need updating too. If the old diagram serves a different purpose in those tutorials, no action needed.

  3. Blank line left behind (cosmetic): At line 835 of concepts/index.mdx, removing the [wiki-olap] link left an empty line between the blank line above and [wiki-view-sql] below, creating a double blank line in the reference links section. Very minor.

Overall this is a clean improvement — removes stale duplicated content, improves page structure, and makes the Concepts page more welcoming. LGTM.

@mintlify
Copy link
Copy Markdown
Contributor

mintlify bot commented Apr 14, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🔴 Failed Apr 14, 2026, 3:58 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant