Improve flags functions

* Also improved if indents

Author: cfnptr

include/math/flags.hpp

@@ -34,13 +34,13 @@ static constexpr enumType operator^(enumType a, enumType b) noexcept    \
 {                                                                       \
 	return (enumType)((uint64)a ^ (uint64)b);                           \
 }                                                                       \
-static constexpr enumType operator!(enumType a) noexcept                \
+static constexpr enumType operator!(enumType v) noexcept                \
 {                                                                       \
-	return (enumType)!((uint64)a);                                      \
+	return (enumType)!((uint64)v);                                      \
 }                                                                       \
-static constexpr enumType operator~(enumType a) noexcept                \
+static constexpr enumType operator~(enumType v) noexcept                \
 {                                                                       \
-	return (enumType)~((uint64)a);                                      \
+	return (enumType)~((uint64)v);                                      \
 }                                                                       \
 static constexpr enumType& operator|=(enumType& a, enumType b) noexcept \
 {                                                                       \
@@ -54,13 +54,21 @@ static constexpr enumType& operator^=(enumType& a, enumType b) noexcept \
 {                                                                       \
 	return a = a ^ b;                                                   \
 }                                                                       \
-static constexpr bool hasAnyFlag(enumType a, enumType flags) noexcept   \
+static constexpr bool hasAnyFlag(enumType v, enumType flags) noexcept   \
 {                                                                       \
-	return (uint64)(a & flags);                                         \
+	return (uint64)(v & flags) ? true : false;                          \
 }                                                                       \
-static constexpr bool hasOneFlag(enumType a, enumType flag) noexcept    \
+static constexpr bool hasOneFlag(enumType v, enumType flag) noexcept    \
 {                                                                       \
-	return (uint64)(a & flag) == (uint64)a;                             \
+	return (v & flag) == v;                                             \
+}                                                                       \
+static constexpr void setFlags(enumType& v, enumType flags) noexcept    \
+{                                                                       \
+	v |= flags;                                                         \
+}                                                                       \
+static constexpr void unsetFlags(enumType& v, enumType flags) noexcept  \
+{                                                                       \
+	v &= ~flags;                                                        \
 }
 
 } // namespace math

include/math/simd/vector/float.hpp

@@ -884,8 +884,7 @@ static f32x4 abs(f32x4 v) noexcept
 	#if defined(MATH_SIMD_SUPPORT_SSE)
 	if constexpr (std::numeric_limits<float>::is_iec559)
 		return _mm_and_ps(v.data, _mm_castsi128_ps(_mm_set1_epi32(0x7FFFFFFF)));
-	else
-		return _mm_max_ps(_mm_sub_ps(_mm_setzero_ps(), v.data), v.data);
+	else return _mm_max_ps(_mm_sub_ps(_mm_setzero_ps(), v.data), v.data);
 	#elif defined(MATH_SIMD_SUPPORT_NEON)
 	return vabsq_f32(v.data);
 	#else

source/bvh.cpp

@@ -330,8 +330,7 @@ void Bvh::recreate(const uint8* vertices, const uint8* indices, const Aabb& root
 		{
 			if (centroidData[primitives[i]][axis] < split)
 				i++;
-			else
-				std::swap(primitives[i], primitives[j--]);
+			else std::swap(primitives[i], primitives[j--]);
 		}
 
 		auto count1 = i - firstPrimitive;
@@ -463,8 +462,7 @@ void Bvh::recreate(const Aabb* aabbs, const Aabb& rootAabb, uint32 aabbCount, co
 		{
 			if (centroidData[primitiveData[i]][axis] < split)
 				i++;
-			else
-				std::swap(primitiveData[i], primitiveData[j--]);
+			else std::swap(primitiveData[i], primitiveData[j--]);
 		}
 
 		auto count1 = i - firstPrimitive;