Fix asynchronous tests

Author: braktar

.github/workflows/main.yml

@@ -92,7 +92,7 @@ jobs:
     env:
       OPTIONS: "COV=false LOG_LEVEL=info SKIP_DICHO=true SKIP_REAL_CASES=true SKIP_PERIODIC=true SKIP_SPLIT_CLUSTERING=true"
       TIMEOUT: 10m
-    steps: &test_steps
+    steps:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Download Docker image
@@ -113,7 +113,20 @@ jobs:
     env:
       OPTIONS: "COV=false LOG_LEVEL=info TEST=test/lib/heuristics/dichotomous_test.rb"
       TIMEOUT: 20m
-    steps: *test_steps
+    steps: &test_steps
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Download Docker image
+        uses: actions/download-artifact@v4
+        with:
+          name: docker-image
+          path: /tmp
+      - name: Load Docker image
+        run: docker load --input /tmp/optimizer-api.tar
+      - name: Launch Stack
+        run: timeout 4m docker compose -f ./docker/docker-compose.simple.test.yml up --wait
+      - name: Starting tests
+        run: timeout ${TIMEOUT} docker compose -f ./docker/docker-compose.simple.test.yml exec api rake test TESTOPTS="${TESTOPTS}" ${OPTIONS}
 
   test_real:
     needs: build

docker/docker-compose.simple.test.yml

@@ -0,0 +1,15 @@
+x-default-service: &default-service
+  image: optimizer-api:latest
+  environment: &default-environment
+    APP_ENV: test
+    BUNDLE_WITH: "test development"
+    LOG_LEVEL: fatal
+    OPTIM_DEFAULT_MAX_LATENESS_RATIO: 1
+    OPTIM_GENERATE_GEOJSON_POLYLINES: 'true'
+
+services:
+  api:
+    <<: *default-service
+    ports:
+      - "8083:80" # HOST:CONTAINER, edit only HOST part
+    command: bundle exec puma -v -p 80 --pidfile 'server.pid'

test/api/v01/helpers/request_helper.rb

@@ -150,44 +150,14 @@ def delete_completed_job(job_id, params)
     JSON.parse(last_response.body)
   end
 
-  def asynchronously(options = {start_worker: false})
+  def asynchronously(_options = {start_worker: false})
     old_config_solve_synchronously = OptimizerWrapper.config[:solve][:synchronously]
     OptimizerWrapper.config[:solve][:synchronously] = false
     old_resque_inline = Resque.inline
     Resque.inline = false
-    if options[:start_worker] && !ENV['DOCKER']
-      pid_worker = Process.spawn({ 'COUNT' => '1', 'QUEUE' => 'DEFAULT' },
-                                 'bundle exec rake resque:workers --trace', pgroup: true) # don't create another shell
-      pgid_worker = Process.getpgid(pid_worker)
-      while `ps -o pgid | grep #{pgid_worker}`.split(/\n/).size < 2
-        puts "#{Time.now} Waiting for the worker to launch"
-        sleep 0.1
-      end
-      puts "#{Time.now} Worker is started"
-      sleep 0.1
-    end
     yield
   ensure
     Resque.inline = old_resque_inline
     OptimizerWrapper.config[:solve][:synchronously] = old_config_solve_synchronously
-    if options[:start_worker] && !ENV['DOCKER'] && pgid_worker
-      # Kill all grandchildren
-      worker_pids = `ps -o pgid,pid | grep #{pgid_worker}`.split(/\n/)
-      worker_pids.collect!{ |i| i.split(' ')[-1].to_i }
-      worker_pids.sort!
-      worker_pids.reverse_each{ |pid|
-        next if pid == pgid_worker
-
-        Process.kill('SIGKILL', pid)
-        Process.detach(pid)
-      }
-      Process.kill('SIGTERM', -pgid_worker) # Kill the process group (this doesn't kill grandchildren)
-      Process.waitpid(-pgid_worker, 0)
-      while `ps -o pgid,pid | grep "#{worker_pids.join('\|')}"`.split(/\n/).any?
-        puts "#{Time.now} Waiting the worker process group #{pgid_worker} to die\n"
-        sleep 0.1
-      end
-      puts "#{Time.now} Worker is killed"
-    end
   end
 end