Fix lint

Author: braktar

api/v01/vrp.rb

@@ -217,7 +217,7 @@ class Vrp < APIBase
           params {
             use(:input)
             optional(:format, type: Symbol, values: [:json, :geojson], default: :json,
-                     desc: 'Output format: json (full graph) or geojson')
+                              desc: 'Output format: json (full graph) or geojson')
           }
           post do
             d_params = declared(params, include_missing: false)
@@ -230,11 +230,12 @@ class Vrp < APIBase
               error!("Model Validation Error: #{vrp.errors}", 400)
             end
 
-            graph = begin
-              VrpGraph::GraphBuilder.new(vrp).build
-            rescue LoadError => e
-              error!({ message: "Graph build failed: #{e.message}" }, 501)
-            end
+            graph =
+              begin
+                VrpGraph::GraphBuilder.new(vrp).build
+              rescue LoadError => e
+                error!({ message: "Graph build failed: #{e.message}" }, 501)
+              end
 
             if graph
               vrp.graph = graph

core/strategies/orchestration.rb

@@ -1,4 +1,4 @@
-require './lib/interpreters/re_partition.rb'
+require './lib/interpreters/re_partition'
 
 module Core
   module Strategies

lib/vrp_graph/batch_assigner.rb

@@ -109,7 +109,7 @@ def build_proximity_matrix
     end
 
     def route_stop_service_ids(route)
-      route.stops.filter_map { |s| s.service_id }.compact.each_with_object({}) { |sid, h| h[sid] = true }
+      route.stops.filter_map(&:service_id).compact.each_with_object({}) { |sid, h| h[sid] = true }
     end
 
     def assign_with_ortools

lib/vrp_graph/delaunay_adapter.rb

@@ -37,7 +37,9 @@ def compute_edges(points)
       return [] if points.size < 2
 
       unless File.executable?(BINARY_PATH)
-        raise LoadError, "vrp_delaunay binary not found. Run: rake ext:vrp_delaunay (expected: #{BINARY_PATH})"
+        raise LoadError.new(
+          "vrp_delaunay binary not found. Run: rake ext:vrp_delaunay (expected: #{BINARY_PATH})"
+        )
       end
 
       input = points.map { |lon, lat| [lon.to_f, lat.to_f] }.to_json

lib/vrp_graph/knn_neighborhood.rb

@@ -33,7 +33,12 @@ module KnnNeighborhood
     # @param k [Integer] max neighbors per repaired point
     # @return [Hash] point_id => [neighbor_point_id, ...] sorted by travel time
     def compute_knn_points(repaired_point_ids, other_point_ids, knn_matrix, point_incompat, k: 10)
-      incompat_set = point_incompat.is_a?(Hash) ? point_incompat : point_incompat.to_h { |a, b| [[a.to_s, b.to_s].sort, true] }
+      incompat_set =
+        if point_incompat.is_a?(Hash)
+          point_incompat
+        else
+          point_incompat.to_h { |a, b| [[a.to_s, b.to_s].sort, true] }
+        end
       result = {}
 
       repaired_point_ids.each_with_index do |pid, i|

models/graph.rb

@@ -92,7 +92,7 @@ def tours_connectivity(ids)
     def tours_connectivity_from_solution(solution)
       result = {}
       solution.routes.each_with_index do |route, idx|
-        service_ids = route.stops.filter_map{ |s| s.service_id }.compact
+        service_ids = route.stops.filter_map(&:service_id).compact
         result[idx] = tours_connectivity(service_ids)
       end
       result
@@ -160,20 +160,21 @@ def to_geojson
 
     # Full adjacency list: Delaunay edges + KNN-repair edges, cached.
     def adjacency
-      @adjacency_cache ||= begin
-        adj = Hash.new { |h, k| h[k] = [] }
-        (edges || []).each do |e|
-          adj[e[0]] << e[1]
-          adj[e[1]] << e[0]
-        end
-        (knn_neighbors || {}).each do |sid, neighbors|
-          neighbors.each do |nb|
-            adj[sid] << nb unless adj[sid].include?(nb)
-            adj[nb] << sid unless adj[nb].include?(sid)
+      @adjacency ||=
+        begin
+          adj = Hash.new { |h, k| h[k] = [] }
+          (edges || []).each do |e|
+            adj[e[0]] << e[1]
+            adj[e[1]] << e[0]
+          end
+          (knn_neighbors || {}).each do |sid, neighbors|
+            neighbors.each do |nb|
+              adj[sid] << nb unless adj[sid].include?(nb)
+              adj[nb] << sid unless adj[nb].include?(sid)
+            end
           end
+          adj
         end
-        adj
-      end
     end
 
     def build_service_ids_by_point
@@ -229,45 +230,48 @@ def neighbors_for_point(point_id)
     end
 
     def knn_neighbors
-      @knn_neighbors_cache ||= begin
-        merged = {}
-        @graphs.each_value do |g|
-          (g.knn_neighbors || {}).each do |sid, neighbors|
-            (merged[sid] ||= []).concat(neighbors)
+      @knn_neighbors ||=
+        begin
+          merged = {}
+          @graphs.each_value do |g|
+            (g.knn_neighbors || {}).each do |sid, neighbors|
+              (merged[sid] ||= []).concat(neighbors)
+            end
           end
+          merged.each_value(&:uniq!)
+          merged
         end
-        merged.each_value(&:uniq!)
-        merged
-      end
     end
 
     def nodes
-      @nodes_cache ||= begin
-        merged = {}
-        @graphs.each_value { |g| merged.merge!(g.nodes || {}) }
-        merged
-      end
+      @nodes ||=
+        begin
+          merged = {}
+          @graphs.each_value { |g| merged.merge!(g.nodes || {}) }
+          merged
+        end
     end
 
     def edges
-      @edges_cache ||= begin
-        seen = {}
-        result = []
-        @graphs.each_value do |g|
-          (g.edges || []).each do |e|
-            pair = [e[0], e[1]].sort
-            next if seen[pair]
-
-            seen[pair] = true
-            result << e
+      @edges ||=
+        begin
+          seen = {}
+          result = []
+          @graphs.each_value do |g|
+            (g.edges || []).each do |e|
+              pair = [e[0], e[1]].sort
+              next if seen[pair]
+
+              seen[pair] = true
+              result << e
+            end
           end
+          result
         end
-        result
-      end
     end
 
     def edge_set
-      @edge_set_cache ||= edges.each_with_object({}) { |e, h| h[[e[0], e[1]].sort] = true }
+      @edge_set ||= edges.each_with_object({}) { |e, h| h[[e[0], e[1]].sort] = true }
     end
 
     def connected?(id_a, id_b)
@@ -292,7 +296,7 @@ def tours_connectivity(ids)
     def tours_connectivity_from_solution(solution)
       result = {}
       solution.routes.each_with_index do |route, idx|
-        service_ids = route.stops.filter_map{ |s| s.service_id }.compact
+        service_ids = route.stops.filter_map(&:service_id).compact
         result[idx] = tours_connectivity(service_ids)
       end
       result

models/vrp.rb

@@ -117,7 +117,8 @@ def find_mission_by_id(mission_id)
         reload_depots.find{ |rd| rd.id == mission_id || rd.original_id == mission_id }
     end
 
-    # Builds Models::Route list from rows produced by Solution#vrp_routes (optionally filtered via Solution.vrp_routes_for_vehicles).
+    # Builds Models::Route list from rows produced by Solution#vrp_routes
+    # (optionally filtered via Solution.vrp_routes_for_vehicles).
     def routes_from_initial_specs(route_specs)
       route_specs.filter_map{ |spec|
         vehicle = vehicles.find{ |v| v.id == spec[:vehicle_id] }

test/lib/vrp_graph/delaunay_adapter_test.rb

@@ -5,12 +5,14 @@
 module VrpGraph
   class DelaunayAdapterTest < Minitest::Test
     def setup
-      skip 'vrp_delaunay binary not built (rake ext:vrp_delaunay)' unless File.executable?(VrpGraph::DelaunayAdapter::BINARY_PATH)
+      return if File.executable?(VrpGraph::DelaunayAdapter::BINARY_PATH)
+
+      skip 'vrp_delaunay binary not built (rake ext:vrp_delaunay)'
     end
 
     def test_compute_edges_returns_empty_for_insufficient_points
-      assert_equal [], DelaunayAdapter.compute_edges([])
-      assert_equal [], DelaunayAdapter.compute_edges([[1.0, 2.0]])
+      assert_empty DelaunayAdapter.compute_edges([])
+      assert_empty DelaunayAdapter.compute_edges([[1.0, 2.0]])
     end
 
     def test_compute_edges_two_points

test/lib/vrp_graph/graph_builder_test.rb

@@ -5,7 +5,9 @@
 module VrpGraph
   class GraphBuilderTest < Minitest::Test
     def setup
-      skip 'vrp_delaunay binary not built (rake ext:vrp_delaunay)' unless File.executable?(VrpGraph::DelaunayAdapter::BINARY_PATH)
+      return if File.executable?(VrpGraph::DelaunayAdapter::BINARY_PATH)
+
+      skip 'vrp_delaunay binary not built (rake ext:vrp_delaunay)'
     end
 
     def test_build_creates_graph_with_service_level_nodes
@@ -99,9 +101,10 @@ def test_intra_point_edges_between_colocated_services
         assert_equal graph.nodes['svc_a'][:point_id], graph.nodes['svc_b'][:point_id],
                      'Co-located services should share the same point_id'
 
-        intra_edge = graph.edges.any?{ |e|
-          [e[0], e[1]].sort == ['svc_a', 'svc_b'].sort
-        }
+        intra_edge =
+          graph.edges.any?{ |e|
+            [e[0], e[1]].sort == ['svc_a', 'svc_b'].sort
+          }
         assert intra_edge, 'Compatible co-located services should have an intra-point edge'
       end
     end