Merge pull request #6 from buildkite-plugins/codex/export-mise-env-hook

fix: export mise env from hooks

Author: lox

.buildkite/pipeline.yml

@@ -1,13 +1,24 @@
 steps:
   - label: ":sparkles: Tests"
     plugins:
-      - plugin-tester#v1.3.0:
-          pull: true
+      - plugin-tester#v1.3.0: ~
 
   - label: ":lint-roller: Lint"
     plugins:
       - plugin-linter#v3.0.0:
-          id: buildkite-plugins/mise
+          id: buildkite/mise
+
+  - label: ":mise: Smoke test"
+    command:
+      - "command -v mise"
+      - "mise --version"
+      - "command -v shellcheck"
+      - "shellcheck --version"
+      - "shellcheck hooks/pre-command tests/pre-command.bats"
+    plugins:
+      - ./: ~
 
   - label: ":shell: Shellcheck"
     command: shellcheck hooks/*
+    plugins:
+      - ./: ~

.tool-versions

@@ -0,0 +1 @@
+shellcheck 0.11.0

README.md

@@ -6,7 +6,7 @@ This plugin is intentionally small:
 
 - `mise` is installed if missing or at the wrong version
 - `mise install` always runs
-- `mise env --shell bash` is always appended to `$BUILDKITE_ENV_FILE`
+- `mise env --shell bash` is sourced in the hook and appended to `$BUILDKITE_ENV_FILE`
 - tool versions come from the repository, not plugin config
 
 ## Example
@@ -15,7 +15,7 @@ This plugin is intentionally small:
 steps:
   - label: ":wrench: Test"
     plugins:
-      - buildkite-plugins/mise#v1.0.0:
+      - buildkite/mise#v1.1.0:
           version: 2026.2.11
     command: go test ./...
 ```
@@ -26,7 +26,7 @@ steps:
 steps:
   - label: ":wrench: Test backend"
     plugins:
-      - buildkite-plugins/mise#v1.0.0:
+      - buildkite/mise#v1.1.0:
           dir: backend
     command: go test ./...
 ```
@@ -39,7 +39,7 @@ cache: ".buildkite/cache-volume"
 steps:
   - label: ":wrench: Test"
     plugins:
-      - buildkite-plugins/mise#v1.0.0: ~
+      - buildkite/mise#v1.1.0: ~
     command: go test ./...
 ```
 
@@ -66,7 +66,8 @@ The target directory must contain one of:
 Run plugin checks locally:
 
 ```bash
-docker run --rm -v "$PWD:/plugin" -w /plugin buildkite/plugin-linter --id buildkite-plugins/mise --path /plugin
+mise install
+docker run --rm -v "$PWD:/plugin" -w /plugin buildkite/plugin-linter --id buildkite/mise --path /plugin
 docker run --rm -v "$PWD:/plugin" -w /plugin buildkite/plugin-tester
 "$(mise where shellcheck@0.11.0)/shellcheck-v0.11.0/shellcheck" hooks/pre-command tests/pre-command.bats
 ```

hooks/pre-command

@@ -42,6 +42,18 @@ append_export() {
   append_to_buildkite_env "$(printf 'export %s=%q' "$name" "$value")"
 }
 
+apply_mise_env() {
+  local mise_env_file
+
+  mise_env_file="$(mktemp)"
+  run_mise env --shell bash | tee -a "$BUILDKITE_ENV_FILE" > "$mise_env_file"
+
+  # Source the generated exports so later host-side hooks inherit the tool env.
+  # shellcheck disable=SC1090
+  . "$mise_env_file"
+  rm -f "$mise_env_file"
+}
+
 cleanup_install_mise() {
   rm -f "$1"
   rm -rf "$2"
@@ -260,7 +272,11 @@ main() {
   append_export MISE_DATA_DIR "$MISE_DIR"
   append_export MISE_TRUSTED_CONFIG_PATHS "$WORKING_DIRECTORY"
   append_export MISE_YES "1"
-  run_mise env --shell bash >> "$BUILDKITE_ENV_FILE"
+
+  export MISE_DATA_DIR="$MISE_DIR"
+  export MISE_TRUSTED_CONFIG_PATHS="$WORKING_DIRECTORY"
+  export MISE_YES="1"
+  apply_mise_env
 
   echo "~~~ :white_check_mark: mise setup complete"
 }

tests/pre-command.bats

@@ -131,6 +131,23 @@ MOCK
   grep -F "export PATH=\"${MISE_DATA_DIR}/installs/go/1.0.0/bin:\$PATH\"" "${BUILDKITE_ENV_FILE}"
 }
 
+@test "exports mise environment in the hook shell" {
+  printf 'go 1.0.0\n' > "${BUILDKITE_BUILD_CHECKOUT_PATH}/.tool-versions"
+
+  run bash -c "
+    . hooks/pre-command >/dev/null
+    env | grep -Fx 'TEST_ENV=ok'
+    env | grep -Fx 'MISE_TRUSTED_CONFIG_PATHS=${BUILDKITE_BUILD_CHECKOUT_PATH}'
+    env | grep -Fx 'MISE_YES=1'
+    case \":\$PATH:\" in
+      *\":${MISE_DATA_DIR}/installs/go/1.0.0/bin:\"*) ;;
+      *) exit 1 ;;
+    esac
+  "
+
+  [ "${status}" -eq 0 ]
+}
+
 @test "uses dir config for monorepos" {
   subdir="${BUILDKITE_BUILD_CHECKOUT_PATH}/backend"
   mkdir -p "${subdir}"