fix: key detectors by config ID to support multiple resources of same type (#21)

## Problem

`aurora-postgresql` and `aurora-mysql` both have `type: aurora` in
`config/resources.yaml`. The detectors map was keyed by resource type,
so the second entry overwrote the first — only 4 detectors were
initialized instead of 5.

## Fix

Key `invSources`, `eolProviders`, and `detectors` maps by **config ID**
(e.g., `aurora-mysql`) instead of resource type (e.g., `aurora`). Update
the orchestrator's default resource list to use config IDs. Remove the
now-unnecessary type verification check in `ListResources`.

## Changes

- `cmd/server/main.go` — key maps by `resourceCfg.ID` instead of
`resourceCfg.Type`
- `pkg/workflow/orchestrator/workflow.go` — default fan-out uses config
IDs
- `pkg/inventory/wiz/generic.go` — remove type check in `ListResources`
(source knows its own type)
- `pkg/inventory/wiz/generic_test.go` — remove obsolete test

## Result

Before: `✓ Total detectors initialized: 4` (aurora collision)
After: `✓ Total detectors initialized: 5` (aurora-postgresql +
aurora-mysql)

Co-authored-by: Amp <amp@ampcode.com>

Author: bakayolo

cmd/server/main.go

@@ -238,6 +238,8 @@ func (s *ServerCLI) Run(_ *kong.Context) error {
 	var registryClient registry.Client
 
 	// Initialize detectors from config
+	// Keyed by config ID (not resource type) to support multiple resources
+	// of the same type (e.g., aurora-postgresql and aurora-mysql both type "aurora")
 	fmt.Println("\nInitializing detectors from configuration...")
 	detectors := make(map[types.ResourceType]interface{})
 	invSources := make(map[types.ResourceType]inventory.InventorySource)
@@ -274,14 +276,14 @@ func (s *ServerCLI) Run(_ *kong.Context) error {
 			continue
 		}
 
-		// Store in maps for Temporal activities
-		resourceType := types.ResourceType(resourceCfg.Type)
-		invSources[resourceType] = invSource
-		eolProviders[resourceType] = eolProvider
+		// Store in maps for Temporal activities, keyed by config ID
+		configID := types.ResourceType(resourceCfg.ID)
+		invSources[configID] = invSource
+		eolProviders[configID] = eolProvider
 
 		// Create generic detector
 		detector := generic.NewDetector(resourceCfg, invSource, eolProvider, policyEngine, logger)
-		detectors[resourceType] = detector
+		detectors[configID] = detector
 		fmt.Printf("    ✓ Generic detector initialized for %s\n", resourceCfg.ID)
 	}
 

pkg/inventory/wiz/generic.go

@@ -71,13 +71,10 @@ func (s *GenericInventorySource) CloudProvider() types.CloudProvider {
 	}
 }
 
-// ListResources fetches resources from Wiz using the configured report
+// ListResources fetches resources from Wiz using the configured report.
+// The resourceType parameter is accepted for interface compatibility but
+// the source uses its own config type internally.
 func (s *GenericInventorySource) ListResources(ctx context.Context, resourceType types.ResourceType) ([]*types.Resource, error) {
-	// Verify resource type matches config
-	if string(resourceType) != s.config.Type {
-		return nil, errors.Errorf("unsupported resource type: %s (expected: %s)", resourceType, s.config.Type)
-	}
-
 	// Get report ID from WIZ_REPORT_IDS map
 	reportID, err := getReportIDFromMap(s.config.ID)
 	if err != nil {
@@ -266,7 +263,7 @@ func (s *GenericInventorySource) parseResourceRow(
 	resource := &types.Resource{
 		ID:             externalID,
 		Name:           name,
-		Type:           types.ResourceType(s.config.Type),
+		Type:           types.ResourceType(s.config.ID),
 		CloudProvider:  s.CloudProvider(),
 		CloudAccountID: accountID,
 		CloudRegion:    region,

pkg/inventory/wiz/generic_test.go

@@ -318,7 +318,7 @@ func TestParseResourceRow(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, "arn:aws:rds:us-west-2:123456789012:cluster:my-cluster", resource.ID)
 	assert.Equal(t, "my-cluster", resource.Name)
-	assert.Equal(t, types.ResourceType("aurora"), resource.Type)
+	assert.Equal(t, types.ResourceType("aurora-postgresql"), resource.Type)
 	assert.Equal(t, types.CloudProviderAWS, resource.CloudProvider)
 	assert.Equal(t, "123456789012", resource.CloudAccountID)
 	assert.Equal(t, "us-west-2", resource.CloudRegion)
@@ -424,21 +424,6 @@ func TestGetRequiredColumns_NoMappings(t *testing.T) {
 	assert.Len(t, columns, 6) // Only the 6 base columns
 }
 
-func TestListResources_UnsupportedResourceType(t *testing.T) {
-	cfg := config.ResourceConfig{
-		ID:   "aurora-postgresql",
-		Type: "aurora",
-	}
-
-	source := NewGenericInventorySource(&Client{}, &cfg, nil, nil)
-
-	ctx := context.Background()
-	_, err := source.ListResources(ctx, types.ResourceType("eks"))
-
-	assert.Error(t, err)
-	assert.Contains(t, err.Error(), "unsupported resource type")
-}
-
 func TestListResources_NoReportID(t *testing.T) {
 	// Ensure WIZ_REPORT_IDS is not set
 	os.Unsetenv("WIZ_REPORT_IDS")

pkg/workflow/orchestrator/workflow.go

@@ -66,11 +66,13 @@ func OrchestratorWorkflow(ctx workflow.Context, input WorkflowInput) (*WorkflowO
 	// Default to all supported resource types if none specified
 	resourceTypes := input.ResourceTypes
 	if len(resourceTypes) == 0 {
-		// Use lowercase resource types that match config file
+		// Use config IDs from resources.yaml (not resource types)
+		// to support multiple resources of the same type
 		resourceTypes = []types.ResourceType{
-			"aurora",
-			"elasticache",
+			"aurora-postgresql",
+			"aurora-mysql",
 			"eks",
+			"elasticache-redis",
 			"opensearch",
 		}
 	}