fix: correctly classify extended support as YELLOW, not RED

Resources past standard support but still in extended support were
incorrectly classified as RED because:
1. convertCycle checked EOL date before extended support window
2. Policy treated IsDeprecated as RED even when IsExtendedSupport was set

Now: extended support check runs first, and policy excludes extended
support resources from RED status. EKS k8s 1.30/1.32 correctly show
as YELLOW with 'in extended support (6x standard cost)' message.

Amp-Thread-ID: https://ampcode.com/threads/T-019d92b6-b80d-731a-8a83-64e6442ae52c
Co-authored-by: Amp <amp@ampcode.com>

Author: bakayolo

pkg/eol/endoflife/provider.go

@@ -297,38 +297,47 @@ func (p *Provider) convertCycle(engine, product string, cycle *ProductCycle) (*t
 		}
 	}
 
-	// Determine lifecycle status based on dates
+	// Determine lifecycle status based on dates.
+	// For products like EKS, the "support" field is absent and "eol" means
+	// end of standard support while "extendedSupport" is the true end of life.
+	// We treat eolDate as the standard support boundary when supportDate is nil.
 	now := time.Now()
 
-	// If we have an EOL date and we're past it, mark as EOL
-	if eolDate != nil && now.After(*eolDate) {
-		lifecycle.IsEOL = true
-		lifecycle.IsSupported = false
-		lifecycle.IsDeprecated = true
-		return lifecycle, nil
+	// Resolve the effective standard-support-end date
+	standardEnd := supportDate
+	if standardEnd == nil {
+		standardEnd = eolDate
 	}
 
-	// If we have extended support end and we're past standard support
-	if extendedSupportDate != nil && supportDate != nil && now.After(*supportDate) {
+	// Check extended support window first — must come before the EOL check
+	// so that resources in extended support get YELLOW, not RED.
+	if extendedSupportDate != nil && standardEnd != nil && now.After(*standardEnd) {
 		if now.Before(*extendedSupportDate) {
 			// In extended support window
 			lifecycle.IsSupported = true
 			lifecycle.IsExtendedSupport = true
 			lifecycle.IsDeprecated = true
 		} else {
-			// Past extended support
+			// Past extended support — truly EOL
 			lifecycle.IsEOL = true
 			lifecycle.IsSupported = false
 			lifecycle.IsDeprecated = true
 		}
 		return lifecycle, nil
 	}
 
-	// If we're past support date but no extended support info
+	// Past EOL with no extended support available
+	if eolDate != nil && now.After(*eolDate) {
+		lifecycle.IsEOL = true
+		lifecycle.IsSupported = false
+		lifecycle.IsDeprecated = true
+		return lifecycle, nil
+	}
+
+	// Past standard support but no extended support info
 	if supportDate != nil && now.After(*supportDate) {
 		lifecycle.IsDeprecated = true
 		lifecycle.IsSupported = false
-		// If we have EOL date, use it; otherwise mark as deprecated but not EOL
 		if eolDate != nil && now.Before(*eolDate) {
 			lifecycle.IsEOL = false
 		}

pkg/policy/default.go

@@ -71,8 +71,8 @@ func (p *DefaultPolicy) isRedStatus(lifecycle *types.VersionLifecycle) bool {
 		return true
 	}
 
-	// Deprecated
-	if lifecycle.IsDeprecated {
+	// Deprecated (but not if still in extended support)
+	if lifecycle.IsDeprecated && !lifecycle.IsExtendedSupport {
 		return true
 	}