Skip to content

Commit 4519849

Browse files
committed
Update success rate calculation
1 parent 1940ecd commit 4519849

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/ps_helper/extensions/metrics_extension.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,14 @@ def spider_closed(self, spider, reason):
108108
interval_size = max(1, math.ceil(total_minutes / self.max_buckets))
109109

110110
# Success rate
111+
successful_requests = self.stats.get_value("downloader/response_count", 0)
111112
total_requests = self.stats.get_value("downloader/request_count", 0)
112-
status_200 = self.http_status_counter.get(200, 0)
113-
success_rate = (status_200 / total_requests * 100) if total_requests > 0 else 0
113+
retries_total = self.stats.get_value("retry/count", 0)
114+
115+
success_rate = (
116+
(successful_requests / (total_requests - retries_total) * 100)
117+
if (total_requests - retries_total) > 0 else 0
118+
)
114119

115120
# Group timeline
116121
aggregated = defaultdict(int)

0 commit comments

Comments
 (0)