0.31.11

atkAudioUser · atkAudioUser · commit cbe832c348f5 · 2026-01-24T01:34:16.000Z
diff --git a/buildspec.json b/buildspec.json
@@ -47,6 +47,6 @@
   "uuids": {
     "windowsApp": "ad885c58-5ca9-44de-8f4f-1c12676626a9"
   },
-  "version": "0.31.10",
+  "version": "0.31.11",
   "website": "https://www.atkaudio.com"
 }
diff --git a/lib/atkaudio/src/atkaudio/DeviceIo/DeviceIo.cpp b/lib/atkaudio/src/atkaudio/DeviceIo/DeviceIo.cpp
@@ -30,37 +30,37 @@ struct atk::DeviceIo::Impl
     void process(float** buffer, int numChannels, int numSamples, double sampleRate)
     {
         bool currentBypass = bypass.load(std::memory_order_acquire);
-        bool wasJustBypassed = wasBypassed.exchange(currentBypass, std::memory_order_acq_rel);
+        float targetGain = currentBypass ? 0.0f : 1.0f;
 
-        if (currentBypass)
-            return;
-
-        // Clear stale data from buffers when transitioning from bypassed to active
-        if (wasJustBypassed)
+        // Update smoother if sample rate or target changed
+        if (fadeGain.getTargetValue() != targetGain)
         {
-            auto& toObsBuffer = deviceIoApp->getToObsBuffer();
-            auto& fromObsBuffer = deviceIoApp->getFromObsBuffer();
-            toObsBuffer.reset();
-            fromObsBuffer.reset();
-            // Start fade-in over one buffer
-            fadeInSamplesRemaining = numSamples;
-            fadeInTotalSamples = numSamples;
+            fadeGain.reset(sampleRate, fadeDurationSeconds);
+
+            // Clear buffers when transitioning from bypass to active
+            if (!currentBypass)
+            {
+                auto& toObsBuffer = deviceIoApp->getToObsBuffer();
+                auto& fromObsBuffer = deviceIoApp->getFromObsBuffer();
+                toObsBuffer.reset();
+                fromObsBuffer.reset();
+            }
+            fadeGain.setTargetValue(targetGain);
         }
 
-        // Apply fade-in ramp if active
-        if (fadeInSamplesRemaining > 0)
+        // Skip processing if fully bypassed
+        if (currentBypass && !fadeGain.isSmoothing())
+            return;
+
+        // Apply fade gain
+        if (fadeGain.isSmoothing())
         {
-            for (int ch = 0; ch < numChannels; ++ch)
+            for (int i = 0; i < numSamples; ++i)
             {
-                auto* channelData = buffer[ch];
-                int fadeStart = fadeInTotalSamples - fadeInSamplesRemaining;
-                for (int i = 0; i < numSamples && fadeInSamplesRemaining > 0; ++i)
-                {
-                    float gain = static_cast<float>(fadeStart + i + 1) / static_cast<float>(fadeInTotalSamples);
-                    channelData[i] *= gain;
-                }
+                float gain = fadeGain.getNextValue();
+                for (int ch = 0; ch < numChannels; ++ch)
+                    buffer[ch][i] *= gain;
             }
-            fadeInSamplesRemaining = std::max(0, fadeInSamplesRemaining - numSamples);
         }
 
         if (tempBuffer.getNumChannels() < numChannels || tempBuffer.getNumSamples() < numSamples)
@@ -242,9 +242,8 @@ struct atk::DeviceIo::Impl
 
     bool mixInput = false;
     std::atomic<bool> bypass{false};
-    std::atomic<bool> wasBypassed{false};
-    int fadeInSamplesRemaining{0};
-    int fadeInTotalSamples{0};
+    juce::SmoothedValue<float, juce::ValueSmoothingTypes::Linear> fadeGain{1.0f};
+    static constexpr double fadeDurationSeconds = 0.5;
 
 public:
     void setBypass(bool v)
diff --git a/lib/atkaudio/src/atkaudio/DeviceIo2/DeviceIo2.cpp b/lib/atkaudio/src/atkaudio/DeviceIo2/DeviceIo2.cpp
@@ -32,9 +32,8 @@ struct atk::DeviceIo2::Impl : public juce::AsyncUpdater
     std::vector<juce::SmoothedValue<float, juce::ValueSmoothingTypes::Linear>> outputDelaySmooth;
     bool delayPrepared = false;
     std::atomic<bool> bypass{false};
-    std::atomic<bool> wasBypassed{false};
-    int fadeInSamplesRemaining{0};
-    int fadeInTotalSamples{0};
+    juce::SmoothedValue<float, juce::ValueSmoothingTypes::Linear> fadeGain{1.0f};
+    static constexpr double fadeDurationSeconds = 0.5;
 
     enum class UpdateType
     {
@@ -199,35 +198,33 @@ struct atk::DeviceIo2::Impl : public juce::AsyncUpdater
     void process(float** buffer, int numChannels, int numSamples, double sampleRate)
     {
         bool currentBypass = bypass.load(std::memory_order_acquire);
-        bool wasJustBypassed = wasBypassed.exchange(currentBypass, std::memory_order_acq_rel);
+        float targetGain = currentBypass ? 0.0f : 1.0f;
 
-        // When bypassed, leave buffer as-is and skip IO routing
-        if (currentBypass)
-            return;
-
-        // Clear stale data from AudioClient buffers when transitioning from bypassed to active
-        if (wasJustBypassed)
+        // Update smoother if target changed
+        if (fadeGain.getTargetValue() != targetGain)
         {
-            audioClient.clearBuffers();
-            // Start fade-in over one buffer
-            fadeInSamplesRemaining = numSamples;
-            fadeInTotalSamples = numSamples;
+            fadeGain.reset(sampleRate, fadeDurationSeconds);
+
+            // Clear buffers when transitioning from bypass to active
+            if (!currentBypass)
+                audioClient.clearBuffers();
+
+            fadeGain.setTargetValue(targetGain);
         }
 
-        // Apply fade-in ramp if active
-        if (fadeInSamplesRemaining > 0)
+        // Skip processing if fully bypassed
+        if (currentBypass && !fadeGain.isSmoothing())
+            return;
+
+        // Apply fade gain
+        if (fadeGain.isSmoothing())
         {
-            for (int ch = 0; ch < numChannels; ++ch)
+            for (int i = 0; i < numSamples; ++i)
             {
-                auto* channelData = buffer[ch];
-                int fadeStart = fadeInTotalSamples - fadeInSamplesRemaining;
-                for (int i = 0; i < numSamples && fadeInSamplesRemaining > 0; ++i)
-                {
-                    float gain = static_cast<float>(fadeStart + i + 1) / static_cast<float>(fadeInTotalSamples);
-                    channelData[i] *= gain;
-                }
+                float gain = fadeGain.getNextValue();
+                for (int ch = 0; ch < numChannels; ++ch)
+                    buffer[ch][i] *= gain;
             }
-            fadeInSamplesRemaining = std::max(0, fadeInSamplesRemaining - numSamples);
         }
         bool needsReconfiguration =
             preparedNumChannels != numChannels || preparedNumSamples < numSamples || preparedSampleRate != sampleRate;
diff --git a/lib/atkaudio/src/atkaudio/ModuleInfrastructure/MidiServer/MidiServer.cpp b/lib/atkaudio/src/atkaudio/ModuleInfrastructure/MidiServer/MidiServer.cpp
@@ -151,13 +151,8 @@ void MidiServer::initialize()
         return;
     }
 
-    auto midiInputs = juce::MidiInput::getAvailableDevices();
-    for (const auto& device : midiInputs)
-    {
-        deviceManager.setMidiInputDeviceEnabled(device.identifier, true);
-        deviceManager.addMidiInputDeviceCallback(device.identifier, this);
-        DBG("[MidiServer] Enabled MIDI input: " + device.name);
-    }
+    // MIDI inputs are now opened on-demand based on client subscriptions
+    // See updateMidiDeviceSubscriptions()
 
     startTimer(10);
     initialized = true;
@@ -179,14 +174,16 @@ void MidiServer::shutdown()
         for (juce::HashMap<juce::String, juce::MidiOutput*>::Iterator it(outputDevices); it.next();)
             delete it.getValue();
         outputDevices.clear();
-        clients.clear();
-    }
 
-    auto midiInputs = juce::MidiInput::getAvailableDevices();
-    for (const auto& device : midiInputs)
-    {
-        deviceManager.setMidiInputDeviceEnabled(device.identifier, false);
-        deviceManager.removeMidiInputDeviceCallback(device.identifier, this);
+        // Disable all enabled MIDI inputs
+        for (const auto& [name, identifier] : enabledInputDevices)
+        {
+            deviceManager.setMidiInputDeviceEnabled(identifier, false);
+            deviceManager.removeMidiInputDeviceCallback(identifier, this);
+        }
+        enabledInputDevices.clear();
+
+        clients.clear();
     }
 
     deviceManager.closeAudioDevice();
@@ -391,23 +388,58 @@ void MidiServer::rebuildClientSnapshot()
 
 void MidiServer::updateMidiDeviceSubscriptions()
 {
-    juce::StringArray neededOutputs;
-    for (auto& [clientPtr, info] : clients)
+    // Collect all needed devices from client subscriptions
+    juce::StringArray neededInputs, neededOutputs;
+    for (const auto& [clientPtr, info] : clients)
+    {
+        for (const auto& device : info.state.subscribedInputDevices)
+            neededInputs.addIfNotAlreadyThere(device);
         for (const auto& device : info.state.subscribedOutputDevices)
             neededOutputs.addIfNotAlreadyThere(device);
+    }
+
+    // Build name->identifier map for available inputs
+    std::unordered_map<juce::String, juce::String> availableInputMap;
+    for (const auto& device : juce::MidiInput::getAvailableDevices())
+        availableInputMap[device.name] = device.identifier;
+
+    // Enable newly needed input devices
+    for (const auto& name : neededInputs)
+    {
+        if (enabledInputDevices.count(name) == 0)
+        {
+            auto it = availableInputMap.find(name);
+            if (it != availableInputMap.end())
+            {
+                deviceManager.setMidiInputDeviceEnabled(it->second, true);
+                deviceManager.addMidiInputDeviceCallback(it->second, this);
+                enabledInputDevices[name] = it->second;
+                DBG("[MidiServer] Enabled MIDI input: " + name);
+            }
+        }
+    }
+
+    // Disable input devices no longer needed
+    for (auto it = enabledInputDevices.begin(); it != enabledInputDevices.end();)
+        if (!neededInputs.contains(it->first))
+        {
+            deviceManager.setMidiInputDeviceEnabled(it->second, false);
+            deviceManager.removeMidiInputDeviceCallback(it->second, this);
+            DBG("[MidiServer] Disabled MIDI input: " + it->first);
+            it = enabledInputDevices.erase(it);
+        }
+        else
+            ++it;
 
-    juce::Array<juce::String> devicesToRemove;
+    // Close output devices no longer needed (they're opened lazily in timerCallback)
     for (juce::HashMap<juce::String, juce::MidiOutput*>::Iterator it(outputDevices); it.next();)
     {
         if (!neededOutputs.contains(it.getKey()))
         {
             delete it.getValue();
-            devicesToRemove.add(it.getKey());
+            outputDevices.remove(it.getKey());
         }
     }
-
-    for (const auto& device : devicesToRemove)
-        outputDevices.remove(device);
 }
 
 } // namespace atk
diff --git a/lib/atkaudio/src/atkaudio/ModuleInfrastructure/MidiServer/MidiServer.h b/lib/atkaudio/src/atkaudio/ModuleInfrastructure/MidiServer/MidiServer.h
@@ -211,6 +211,7 @@ class MidiServer
     std::unordered_map<void*, ClientInfo> clients;
     AtomicSharedPtr<DeviceSnapshot> activeSnapshot{std::make_shared<DeviceSnapshot>()};
     juce::HashMap<juce::String, juce::MidiOutput*> outputDevices;
+    std::unordered_map<juce::String, juce::String> enabledInputDevices; // name -> identifier
     bool initialized = false;
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(MidiServer)
diff --git a/lib/atkaudio/src/atkaudio/PluginHost2/Core/ObsOutput.h b/lib/atkaudio/src/atkaudio/PluginHost2/Core/ObsOutput.h

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,6 @@`
`47`	`47`	`"uuids": {`
`48`	`48`	`"windowsApp": "ad885c58-5ca9-44de-8f4f-1c12676626a9"`
`49`	`49`	`},`
`50`		`- "version": "0.31.10",`
	`50`	`+ "version": "0.31.11",`
`51`	`51`	`"website": "https://www.atkaudio.com"`
`52`	`52`	`}`