PHP CS

Author: Arnaud RITTI

deploy.php

@@ -18,7 +18,7 @@
 ]);
 
 set('shared_files', [
-    '.env.local'
+    '.env.local',
 ]);
 
 set('writable_dirs', [

package.json

@@ -28,6 +28,11 @@
     "release": "release-it"
   },
   "lint-staged": {
+    "*.php": [
+      "vendor/bin/php-cs-fixer fix --diff --config .php-cs-fixer.dist.php --no-ansi",
+      "vendor/bin/phpcs --no-colors",
+      "vendor/bin/phpstan analyse --no-ansi --no-progress"
+    ],
     "*.{js,jsx,ts,tsx,vue}": [
       "prettier --write",
       "npm run lint:js --"

phpinsights.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 return [
-
     /*
     |--------------------------------------------------------------------------
     | Default Preset
@@ -101,5 +100,4 @@
     */
 
     'threads' => null,
-
 ];

src/Command/BucketsRemoveExpiredCommand.php

@@ -34,7 +34,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->binManager->setBinByUuid($binId);
             if ($this->binManager->isExpired()) {
                 $this->binManager->deleteBin();
-                $deleted++;
+                ++$deleted;
             }
         }
 

src/Controller/API/CookieController.php

@@ -35,7 +35,7 @@ public function __construct(
     public function getCookies(Request $request): Response
     {
         return $this->json([
-            'cookies' => array_filter($request->cookies->all(), static fn ($key) => $key !== 'sf_redirect', ARRAY_FILTER_USE_KEY),
+            'cookies' => array_filter($request->cookies->all(), static fn ($key) => 'sf_redirect' !== $key, ARRAY_FILTER_USE_KEY),
         ], Response::HTTP_OK);
     }
 
@@ -59,6 +59,7 @@ public function newCookie(Request $request): Response
 
             $response = $this->json($requestPayload, Response::HTTP_CREATED);
             $response->headers->setCookie($requestPayload->toCookie());
+
             return $response;
         } catch (MissingConstructorArgumentsException) {
             return $this->json(
@@ -71,23 +72,25 @@ public function newCookie(Request $request): Response
     #[Route('/cookies/{key}', name: 'api.cookies.update', methods: ['PATCH'])]
     public function updateCookie(Request $request, string $key): Response
     {
-        if (! $request->cookies->has($key)) {
+        if (!$request->cookies->has($key)) {
             return $this->json(sprintf('No cookie found for key "%s"', $key), Response::HTTP_NOT_FOUND);
         }
         $requestPayload = new CookieRequestPayload($key, $request->getContent());
         $response = $this->json($requestPayload, Response::HTTP_OK);
         $response->headers->setCookie($requestPayload->toCookie());
+
         return $response;
     }
 
     #[Route('/cookies/{key}', name: 'api.cookies.delete', methods: ['DELETE'])]
     public function deleteCookie(Request $request, string $key): Response
     {
-        if (! $request->cookies->has($key)) {
+        if (!$request->cookies->has($key)) {
             return $this->json(sprintf('No cookie found for key "%s"', $key), Response::HTTP_NOT_FOUND);
         }
         $response = $this->json(sprintf('The cookie with key %s is deleted', $key), Response::HTTP_OK);
         $response->headers->clearCookie($key);
+
         return $response;
     }
 
@@ -227,14 +230,15 @@ public static function setupOpenApiDocumentation(OpenApi $openApi): void
         $openApi->getPaths()->addPath('/cookies/{key}', $singleItem);
     }
 
-    #[Pure] private function createErrorFromSerialization(): FormErrorRfc7807DTO
-    {
-        $mainDto = new FormErrorRfc7807DTO();
-        $mainDto->title = 'Bad Request';
-        $mainDto->type = 'Missing JSON node';
+    #[Pure]
+ private function createErrorFromSerialization(): FormErrorRfc7807DTO
+ {
+     $mainDto = new FormErrorRfc7807DTO();
+     $mainDto->title = 'Bad Request';
+     $mainDto->type = 'Missing JSON node';
 
-        return $mainDto;
-    }
+     return $mainDto;
+ }
 
     private function createErrorFromValidation(ConstraintViolationListInterface $violations): FormErrorRfc7807DTO
     {

src/Controller/API/ImageController.php

@@ -28,19 +28,19 @@ public function getPlaceholder(Request $request, string $dimensions, string $for
         [$width, $height] = self::parseDimensions($dimensions);
 
         $bgColor = $request->query->get('bgColor', '#2b2d42');
-        $bgColor = $bgColor === 'random' ? null : $bgColor;
+        $bgColor = 'random' === $bgColor ? null : $bgColor;
 
         $textColor = $request->query->get('textColor', '#edf2f4');
-        $textColor = $textColor === 'random' ? null : $textColor;
+        $textColor = 'random' === $textColor ? null : $textColor;
 
         $projectRoot = $this->getParameter('kernel.project_dir');
 
         ob_start();
         (new ImageGenerator(
-            $width . 'x' . $height,
+            $width.'x'.$height,
             $textColor,
             $bgColor,
-            $projectRoot . '/var/fonts/Noto.ttf',
+            $projectRoot.'/var/fonts/Noto.ttf',
             min($width, $height) * 0.125,
             2
         ))
@@ -62,7 +62,7 @@ public function getPlaceholder(Request $request, string $dimensions, string $for
     public function getSpace(Request $request, string $dimensions, string $category = 'random', string $format = 'png'): Response
     {
         [$width, $height] = self::parseDimensions($dimensions);
-        $url = sprintf('https://api.lorem.space/image%s?w=%s&h=%s', $category && $category !== 'random' ? '/'.$category : '', $width ? $width : '', $height ? $height : '');
+        $url = sprintf('https://api.lorem.space/image%s?w=%s&h=%s', $category && 'random' !== $category ? '/'.$category : '', $width ? $width : '', $height ? $height : '');
         $client = HttpClient::create();
         $response = $client->request('GET', $url);
 
@@ -161,7 +161,7 @@ private function renderImage(string $content, string $format = 'png'): Response
         $content = ob_get_clean();
 
         $response = new Response();
-        $disposition = $response->headers->makeDisposition(ResponseHeaderBag::DISPOSITION_INLINE, uniqid('', true). ".${format}");
+        $disposition = $response->headers->makeDisposition(ResponseHeaderBag::DISPOSITION_INLINE, uniqid('', true).".${format}");
         $response->headers->set('Content-Disposition', $disposition);
         $response->headers->set('Content-Type', $mimeType);
         $response->setContent($content);
@@ -172,10 +172,11 @@ private function renderImage(string $content, string $format = 'png'): Response
     private static function parseDimensions(string $dimensions): array
     {
         $dimensions = explode('x', $dimensions);
-        if (count($dimensions) === 1) {
+        if (1 === count($dimensions)) {
             $dimensions[1] = $dimensions[0];
         }
         $dimensions = implode('x', $dimensions);
+
         return explode('x', $dimensions);
     }
 }

src/Controller/API/RequestController.php

@@ -51,7 +51,7 @@ public function getAnything(Request $request): Response
             'headers' => array_map(static fn ($entry) => implode('', $entry), $request->headers->all()),
             'content-type' => $request->getContentType(),
             'raw_body' => $request->getContent(),
-            'body' => $request->getContentType() === 'json' ? json_decode($request->getContent(), false, 512, JSON_THROW_ON_ERROR) : $request->getContent(),
+            'body' => 'json' === $request->getContentType() ? json_decode($request->getContent(), false, 512, JSON_THROW_ON_ERROR) : $request->getContent(),
         ]);
     }
 

src/Controller/API/StatusController.php

@@ -18,7 +18,7 @@ class StatusController extends AbstractController
     #[Route('/status/{code}', name: 'api.status.code', methods: ['DELETE', 'GET', 'POST', 'PUT', 'PATCH'])]
     public function getStatusCode(string $code): Response
     {
-        if (! array_key_exists($code, Response::$statusTexts)) {
+        if (!array_key_exists($code, Response::$statusTexts)) {
             return new Response('Invalid status code', Response::HTTP_BAD_REQUEST);
         }
 

src/Controller/Http/BinController.php

@@ -37,7 +37,7 @@ public function __construct(private BinManager $binManager)
     public function bin(Request $request): Response
     {
         $this->binManager->setCurrentBin($request->attributes->get('_bin'));
-        if ($request->getContentType() === 'json' && $request->getContent()) {
+        if ('json' === $request->getContentType() && $request->getContent()) {
             $data = json_decode($request->getContent(), true, 512, JSON_THROW_ON_ERROR);
             $request->request->replace(is_array($data) ? $data : []);
         }
@@ -50,6 +50,7 @@ public function bin(Request $request): Response
                 'bin' => (string) $this->binManager->getCurrentBin(),
             ]), $requestBinId),
         ]);
+
         return $response;
     }
 
@@ -60,6 +61,7 @@ public static function getBaseHost(Request $request)
         if (Uuid::isValid($pathInfo)) {
             $baseHost = str_replace("${pathInfo}.", '', $baseHost);
         }
+
         return $baseHost;
     }
 }

src/Controller/Http/DocumentationController.php

@@ -35,7 +35,7 @@ public function tag(string $tag): Response
     {
         $paths = [];
         /**
-         * @var string $path
+         * @var string   $path
          * @var PathItem $pathItem
          */
         foreach ($this->openApi->getPaths()->getPaths() as $path => $pathItem) {
@@ -59,7 +59,7 @@ public function tag(string $tag): Response
 
             foreach ($operations as $operation) {
                 foreach ($operation->getTags() as $tagName) {
-                    if (! isset($paths[$tagName])) {
+                    if (!isset($paths[$tagName])) {
                         $paths[$tagName] = [];
                     }
                     $paths[$tagName][$path] = $pathItem;