No need to end exception messages with an exclamation!

Author: garydgregory

src/main/java/org/apache/commons/lang3/concurrent/BackgroundInitializer.java

@@ -300,7 +300,7 @@ public final synchronized ExecutorService getExternalExecutor() {
      */
     public synchronized Future<T> getFuture() {
         if (future == null) {
-            throw new IllegalStateException("start() must be called first!");
+            throw new IllegalStateException("start() must be called first.");
         }
         return future;
     }
@@ -377,7 +377,7 @@ public synchronized boolean isStarted() {
      */
     public final synchronized void setExternalExecutor(final ExecutorService externalExecutor) {
         if (isStarted()) {
-            throw new IllegalStateException("Cannot set ExecutorService after start()!");
+            throw new IllegalStateException("Cannot set ExecutorService after start().");
         }
         this.externalExecutor = externalExecutor;
     }

src/main/java/org/apache/commons/lang3/concurrent/MultiBackgroundInitializer.java

@@ -255,7 +255,7 @@ public void addInitializer(final String name, final BackgroundInitializer<?> bac
         Objects.requireNonNull(backgroundInitializer, "backgroundInitializer");
         synchronized (this) {
             if (isStarted()) {
-                throw new IllegalStateException("addInitializer() must not be called after start()!");
+                throw new IllegalStateException("addInitializer() must not be called after start().");
             }
             childInitializers.put(name, backgroundInitializer);
         }

src/main/java/org/apache/commons/lang3/concurrent/TimedSemaphore.java

@@ -421,7 +421,7 @@ public synchronized boolean isShutdown() {
      */
     private void prepareAcquire() {
         if (isShutdown()) {
-            throw new IllegalStateException("TimedSemaphore is shut down!");
+            throw new IllegalStateException("TimedSemaphore is shut down.");
         }
         if (task == null) {
             task = startTimer();

src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java

@@ -140,7 +140,7 @@ void testAbbreviate_StringStringIntInt() {
         assertEquals("cde", StringUtils.abbreviate("abcdefg", "", 2, 3));
         assertIllegalArgumentException(() -> StringUtils.abbreviate("abcdefghij", "::", 0, 2),
                 "StringUtils.abbreviate expecting IllegalArgumentException");
-        assertIllegalArgumentException(() -> StringUtils.abbreviate("abcdefghij", "!!!", 5, 6),
+        assertIllegalArgumentException(() -> StringUtils.abbreviate("abcdefghij", "!!.", 5, 6),
                 "StringUtils.abbreviate expecting IllegalArgumentException");
         final String raspberry = "raspberry peach";
         assertEquals("raspberry peach", StringUtils.abbreviate(raspberry, "--", 12, 15));

src/test/java/org/apache/commons/lang3/text/StrSubstitutorTest.java

@@ -204,11 +204,11 @@ void testCyclicReplacement() {
         map.put("critterColor", "brown");
         map.put("critterType", "${animal}");
         final StrSubstitutor sub = new StrSubstitutor(map);
-        assertThrows(IllegalStateException.class, () -> sub.replace("The ${animal} jumps over the ${target}."), "Cyclic replacement was not detected!");
+        assertThrows(IllegalStateException.class, () -> sub.replace("The ${animal} jumps over the ${target}."), "Cyclic replacement was not detected.");
         // also check even when default value is set.
         map.put("critterType", "${animal:-fox}");
         final StrSubstitutor sub2 = new StrSubstitutor(map);
-        assertThrows(IllegalStateException.class, () -> sub2.replace("The ${animal} jumps over the ${target}."), "Cyclic replacement was not detected!");
+        assertThrows(IllegalStateException.class, () -> sub2.replace("The ${animal} jumps over the ${target}."), "Cyclic replacement was not detected.");
     }
 
     @Test