refactor(multiple): use effect for setting contentVisible

Author: adolgachev

src/aria/accordion/accordion-panel.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import {Directive, afterRenderEffect, computed, inject, input} from '@angular/core';
+import {Directive, effect, computed, inject, input} from '@angular/core';
 import {_IdGenerator} from '@angular/cdk/a11y';
 import {DeferredContentAware, AccordionTriggerPattern} from '../private';
 
@@ -65,8 +65,8 @@ export class AccordionPanel {
   _pattern?: AccordionTriggerPattern;
 
   constructor() {
-    // Connect the panel's hidden state to the DeferredContentAware's visibility.
-    afterRenderEffect(() => {
+    effect(() => {
+      // Connect the panel's hidden state to the DeferredContentAware's visibility.
       this._deferredContentAware.contentVisible.set(this.visible());
     });
   }

src/aria/combobox/combobox.ts

@@ -7,12 +7,12 @@
  */
 
 import {
-  afterRenderEffect,
+  Directive,
+  ElementRef,
   booleanAttribute,
   computed,
   contentChild,
-  Directive,
-  ElementRef,
+  effect,
   inject,
   input,
   signal,
@@ -134,13 +134,13 @@ export class Combobox<V> {
   });
 
   constructor() {
-    afterRenderEffect(() => {
+    effect(() => {
       if (this.alwaysExpanded()) {
         this._pattern.expanded.set(true);
       }
     });
 
-    afterRenderEffect(() => {
+    effect(() => {
       if (
         !this._deferredContentAware?.contentVisible() &&
         (this._pattern.isFocused() || this.alwaysExpanded())

src/aria/menu/menu.ts

@@ -7,12 +7,13 @@
  */
 
 import {
+  Directive,
+  ElementRef,
   afterRenderEffect,
   booleanAttribute,
   computed,
   contentChildren,
-  Directive,
-  ElementRef,
+  effect,
   inject,
   input,
   output,
@@ -154,7 +155,7 @@ export class Menu<V> {
       itemSelected: (value: V) => this.itemSelected.emit(value),
     });
 
-    afterRenderEffect(() => {
+    effect(() => {
       const parent = this.parent();
       if (parent instanceof MenuItem && parent.parent instanceof MenuBar) {
         this._deferredContentAware?.contentVisible.set(true);

src/aria/tabs/tab-panel.ts

@@ -11,9 +11,9 @@ import {
   computed,
   Directive,
   ElementRef,
+  effect,
   inject,
   input,
-  afterRenderEffect,
   OnInit,
   OnDestroy,
 } from '@angular/core';
@@ -90,7 +90,7 @@ export class TabPanel implements OnInit, OnDestroy {
   });
 
   constructor() {
-    afterRenderEffect(() => this._deferredContentAware.contentVisible.set(this.visible()));
+    effect(() => this._deferredContentAware.contentVisible.set(this.visible()));
   }
 
   ngOnInit() {

src/aria/tree/tree-item.ts

@@ -9,7 +9,6 @@
 import {
   Directive,
   ElementRef,
-  afterRenderEffect,
   booleanAttribute,
   computed,
   inject,
@@ -20,6 +19,7 @@ import {
   OnInit,
   OnDestroy,
   afterNextRender,
+  effect,
 } from '@angular/core';
 import {_IdGenerator} from '@angular/cdk/a11y';
 import {ComboboxTreePattern, TreeItemPattern, DeferredContentAware} from '../private';
@@ -128,11 +128,12 @@ export class TreeItem<V> extends DeferredContentAware implements OnInit, OnDestr
         this.preserveContent.set(true);
       }
     });
-    // Connect the group's hidden state to the DeferredContentAware's visibility.
-    afterRenderEffect(() => {
-      this.tree()._pattern instanceof ComboboxTreePattern
-        ? this.contentVisible.set(true)
-        : this.contentVisible.set(this._pattern.expanded());
+
+    effect(() => {
+      // Connect the group's hidden state to the DeferredContentAware's visibility.
+      this.contentVisible.set(
+        this.tree()._pattern instanceof ComboboxTreePattern || this._pattern.expanded(),
+      );
     });
   }