fix(auth): resolve crawler profile defaults

Load the default profile before persisting crawler credentials and add crawler auth test support in the config stub. This keeps `algolia auth crawler` working without `--profile` and restores regression coverage for the new auth flow.

Author: 8bittitan

api/dashboard/client.go

@@ -337,6 +337,58 @@ func (c *Client) ListRegions(accessToken string) ([]Region, error) {
 	return regionsResp.RegionCodes, nil
 }
 
+func (c *Client) GetCrawlerMe(accessToken string) (*CrawlerUserData, error) {
+	req, err := http.NewRequest(http.MethodGet, c.APIURL+"/1/crawler/me", nil)
+	if err != nil {
+		return nil, err
+	}
+
+	c.setAPIHeaders(req, accessToken)
+
+	resp, err := c.client.Do(req)
+	if err != nil {
+		return nil, err
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusOK {
+		return nil, fmt.Errorf("crawler me failed with status: %d", resp.StatusCode)
+	}
+
+	var meResp CrawlerMeResponse
+	if err := json.NewDecoder(resp.Body).Decode(&meResp); err != nil {
+		return nil, fmt.Errorf("failed to parse crawler response: %w", err)
+	}
+
+	return &meResp.Data, nil
+}
+
+func (c *Client) GetCrawlerAPIKey(accessToken string) (string, error) {
+	req, err := http.NewRequest(http.MethodGet, c.APIURL+"/1/crawler/api_key", nil)
+	if err != nil {
+		return "", err
+	}
+
+	c.setAPIHeaders(req, accessToken)
+
+	resp, err := c.client.Do(req)
+	if err != nil {
+		return "", err
+	}
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusOK {
+		return "", fmt.Errorf("crawler me failed with status: %d", resp.StatusCode)
+	}
+
+	var apiKeyResp CrawlerAPIKeyResponse
+	if err := json.NewDecoder(resp.Body).Decode(&apiKeyResp); err != nil {
+		return "", fmt.Errorf("failed to parse crawler response: %w", err)
+	}
+
+	return apiKeyResp.Data.APIKey, nil
+}
+
 func (c *Client) setAPIHeaders(req *http.Request, accessToken string) {
 	req.Header.Set("Authorization", "Bearer "+accessToken)
 	req.Header.Set("Accept", "application/vnd.api+json")

api/dashboard/types.go

@@ -88,6 +88,24 @@ type OAuthErrorResponse struct {
 	ErrorDescription string `json:"error_description"`
 }
 
+type CrawlerUserData struct {
+	ID string `json:"id"`
+}
+
+type CrawlerMeResponse struct {
+	Success bool            `json:"success"`
+	Data    CrawlerUserData `json:"data"`
+}
+
+type CrawlerAPIKeyData struct {
+	APIKey string `json:"apiKey"`
+}
+
+type CrawlerAPIKeyResponse struct {
+	Success bool              `json:"success"`
+	Data    CrawlerAPIKeyData `json:"data"`
+}
+
 // toApplication flattens a JSON:API resource into a simple Application.
 func (r *ApplicationResource) toApplication() Application {
 	return Application{

pkg/cmd/auth/auth.go

@@ -4,6 +4,7 @@ import (
 	"github.com/spf13/cobra"
 
 	"github.com/algolia/cli/pkg/auth"
+	"github.com/algolia/cli/pkg/cmd/auth/crawler"
 	"github.com/algolia/cli/pkg/cmd/auth/login"
 	"github.com/algolia/cli/pkg/cmd/auth/logout"
 	"github.com/algolia/cli/pkg/cmd/auth/signup"
@@ -22,6 +23,7 @@ func NewAuthCmd(f *cmdutil.Factory) *cobra.Command {
 	cmd.AddCommand(login.NewLoginCmd(f))
 	cmd.AddCommand(logout.NewLogoutCmd(f))
 	cmd.AddCommand(signup.NewSignupCmd(f))
+	cmd.AddCommand(crawler.NewCrawlerCmd(f))
 
 	return cmd
 }

pkg/cmd/auth/crawler/crawler.go

@@ -0,0 +1,88 @@
+package crawler
+
+import (
+	"fmt"
+
+	"github.com/algolia/cli/api/dashboard"
+	"github.com/algolia/cli/pkg/auth"
+	"github.com/algolia/cli/pkg/cmd/auth/login"
+	"github.com/algolia/cli/pkg/cmdutil"
+	"github.com/algolia/cli/pkg/config"
+	"github.com/algolia/cli/pkg/iostreams"
+	"github.com/algolia/cli/pkg/validators"
+	"github.com/spf13/cobra"
+)
+
+type CrawlerOptions struct {
+	IO                 *iostreams.IOStreams
+	config             config.IConfig
+	NewDashboardClient func(clientID string) *dashboard.Client
+	GetValidToken      func(client *dashboard.Client) (string, error)
+}
+
+func NewCrawlerCmd(f *cmdutil.Factory) *cobra.Command {
+	opts := &CrawlerOptions{
+		IO:     f.IOStreams,
+		config: f.Config,
+		NewDashboardClient: func(clientID string) *dashboard.Client {
+			return dashboard.NewClient(clientID)
+		},
+		GetValidToken: auth.GetValidToken,
+	}
+
+	cmd := &cobra.Command{
+		Use:   "crawler",
+		Short: "Load crawler auth details for the current profile",
+		Args:  validators.NoArgs(),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return runCrawlerCmd(opts)
+		},
+	}
+
+	return cmd
+}
+
+func runCrawlerCmd(opts *CrawlerOptions) error {
+	cs := opts.IO.ColorScheme()
+	dashboardClient := opts.NewDashboardClient(login.OAuthClientID())
+
+	accessToken, err := opts.GetValidToken(dashboardClient)
+	if err != nil {
+		return err
+	}
+
+	opts.IO.StartProgressIndicatorWithLabel("Fetching crawler information")
+	crawlerUserData, err := dashboardClient.GetCrawlerMe(accessToken)
+	if err != nil {
+		opts.IO.StopProgressIndicator()
+		return err
+	}
+
+	crawlerAPIKey, err := dashboardClient.GetCrawlerAPIKey(accessToken)
+	opts.IO.StopProgressIndicator()
+	if err != nil {
+		return err
+	}
+
+	currentProfileName := opts.config.Profile().Name
+	if currentProfileName == "" {
+		defaultProfile := opts.config.Default()
+		if defaultProfile != nil {
+			currentProfileName = defaultProfile.Name
+			opts.config.Profile().Name = currentProfileName
+		}
+	}
+	if currentProfileName == "" {
+		return fmt.Errorf("no profile selected and no default profile configured")
+	}
+
+	if err = opts.config.SetCrawlerAuth(currentProfileName, crawlerUserData.ID, crawlerAPIKey); err != nil {
+		return err
+	}
+
+	if opts.IO.IsStdoutTTY() {
+		fmt.Fprintf(opts.IO.Out, "%s Crawler API auth credentials configured for profile: %s\n", cs.SuccessIcon(), currentProfileName)
+	}
+
+	return nil
+}

pkg/cmd/auth/crawler/crawler_test.go

@@ -0,0 +1,100 @@
+package crawler
+
+import (
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/algolia/cli/api/dashboard"
+	"github.com/algolia/cli/pkg/config"
+	"github.com/algolia/cli/pkg/iostreams"
+	"github.com/algolia/cli/test"
+)
+
+func Test_runCrawlerCmd_UsesDefaultProfile(t *testing.T) {
+	io, _, stdout, _ := iostreams.Test()
+	io.SetStdoutTTY(true)
+
+	cfg := test.NewConfigStubWithProfiles([]*config.Profile{
+		{Name: "default", Default: true},
+		{Name: "other"},
+	})
+	cfg.CurrentProfile.Name = ""
+
+	server := newCrawlerTestServer(t, "token-1", "crawler-user", "crawler-key")
+	t.Cleanup(server.Close)
+
+	err := runCrawlerCmd(&CrawlerOptions{
+		IO:                 io,
+		config:             cfg,
+		NewDashboardClient: newDashboardTestClient(server),
+		GetValidToken: func(client *dashboard.Client) (string, error) {
+			return "token-1", nil
+		},
+	})
+	require.NoError(t, err)
+
+	assert.Equal(t, "default", cfg.CurrentProfile.Name)
+	assert.Equal(t, test.CrawlerAuth{UserID: "crawler-user", APIKey: "crawler-key"}, cfg.CrawlerAuth["default"])
+	assert.Contains(t, stdout.String(), "configured for profile: default")
+}
+
+func Test_runCrawlerCmd_UsesExplicitProfile(t *testing.T) {
+	io, _, stdout, _ := iostreams.Test()
+	io.SetStdoutTTY(true)
+
+	cfg := test.NewConfigStubWithProfiles([]*config.Profile{
+		{Name: "target"},
+		{Name: "default", Default: true},
+	})
+	cfg.CurrentProfile.Name = "target"
+
+	server := newCrawlerTestServer(t, "token-2", "crawler-user-2", "crawler-key-2")
+	t.Cleanup(server.Close)
+
+	err := runCrawlerCmd(&CrawlerOptions{
+		IO:                 io,
+		config:             cfg,
+		NewDashboardClient: newDashboardTestClient(server),
+		GetValidToken: func(client *dashboard.Client) (string, error) {
+			return "token-2", nil
+		},
+	})
+	require.NoError(t, err)
+
+	assert.Equal(t, test.CrawlerAuth{UserID: "crawler-user-2", APIKey: "crawler-key-2"}, cfg.CrawlerAuth["target"])
+	_, hasDefault := cfg.CrawlerAuth["default"]
+	assert.False(t, hasDefault)
+	assert.Contains(t, stdout.String(), "configured for profile: target")
+}
+
+func newCrawlerTestServer(t *testing.T, token, userID, apiKey string) *httptest.Server {
+	t.Helper()
+
+	return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		require.Equal(t, "Bearer "+token, r.Header.Get("Authorization"))
+
+		switch r.URL.Path {
+		case "/1/crawler/me":
+			_, err := fmt.Fprintf(w, `{"success":true,"data":{"id":%q}}`, userID)
+			require.NoError(t, err)
+		case "/1/crawler/api_key":
+			_, err := fmt.Fprintf(w, `{"success":true,"data":{"apiKey":%q}}`, apiKey)
+			require.NoError(t, err)
+		default:
+			t.Fatalf("unexpected path: %s", r.URL.Path)
+		}
+	}))
+}
+
+func newDashboardTestClient(server *httptest.Server) func(string) *dashboard.Client {
+	return func(clientID string) *dashboard.Client {
+		client := dashboard.NewClientWithHTTPClient(clientID, server.Client())
+		client.APIURL = server.URL
+		return client
+	}
+}

pkg/config/config.go

@@ -26,6 +26,8 @@ type IConfig interface {
 	ApplicationIDExists(appID string) (bool, string)
 	ApplicationIDForProfile(profileName string) (bool, string)
 
+	SetCrawlerAuth(profileName, crawlerUserID, crawlerAPIKey string) error
+
 	Profile() *Profile
 	Default() *Profile
 }
@@ -148,16 +150,12 @@ func (c *Config) RemoveProfile(name string) error {
 
 // SetDefaultProfile set the default profile
 func (c *Config) SetDefaultProfile(name string) error {
-	runtimeViper := viper.GetViper()
-
-	// Below is necessary if the config file was just created
-	runtimeViper.SetConfigType("toml")
-	err := runtimeViper.ReadInConfig()
+	configuration, err := c.read()
 	if err != nil {
 		return err
 	}
 
-	configs := runtimeViper.AllSettings()
+	configs := configuration.AllSettings()
 
 	found := false
 
@@ -175,7 +173,7 @@ func (c *Config) SetDefaultProfile(name string) error {
 		return fmt.Errorf("profile '%s' not found", name)
 	}
 
-	return c.write(runtimeViper)
+	return c.write(configuration)
 }
 
 // ApplicationIDExists check if an application ID exists in any profiles
@@ -200,6 +198,47 @@ func (c *Config) ApplicationIDForProfile(profileName string) (bool, string) {
 	return false, ""
 }
 
+// SetCrawlerAuth sets the config properties for crawler public api
+func (c *Config) SetCrawlerAuth(profile, crawlerUserID, crawlerAPIKey string) error {
+	configuration, err := c.read()
+	if err != nil {
+		return err
+	}
+
+	profiles := configuration.AllSettings()
+
+	found := false
+
+	for profileName := range profiles {
+		runtimeViper := viper.GetViper()
+
+		if profileName == profile {
+			found = true
+			runtimeViper.Set(profileName+".crawler_user_id", crawlerUserID)
+			runtimeViper.Set(profileName+".crawler_api_key", crawlerAPIKey)
+		}
+	}
+
+	if !found {
+		return fmt.Errorf("profile '%s' not found", profile)
+	}
+
+	return c.write(configuration)
+}
+
+// read reads the configuration file and returns its runtime
+func (c *Config) read() (*viper.Viper, error) {
+	runtimeViper := viper.GetViper()
+
+	runtimeViper.SetConfigType("toml")
+	err := runtimeViper.ReadInConfig()
+	if err != nil {
+		return nil, err
+	}
+
+	return runtimeViper, nil
+}
+
 // write writes the configuration file
 func (c *Config) write(runtimeViper *viper.Viper) error {
 	configFile := viper.ConfigFileUsed()