Skip to content

Commit 4542fa8

Browse files
committed
fix(ast): rename shadowed variable in ArrayJoin SQL() serialization
The loop variable `s` shadowed the receiver `s *SelectStatement` in the ARRAY JOIN SQL() block. Renamed to `elemStr` to satisfy gocritic shadow check. https://claude.ai/code/session_01KHvVJ6V1t2nmkaZQkS5Ge3
1 parent 3d62cf9 commit 4542fa8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

pkg/sql/ast/sql.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -570,11 +570,11 @@ func (s *SelectStatement) SQL() string {
570570
}
571571
elems := make([]string, len(s.ArrayJoin.Elements))
572572
for i, e := range s.ArrayJoin.Elements {
573-
s := exprSQL(e.Expr)
573+
elemStr := exprSQL(e.Expr)
574574
if e.Alias != "" {
575-
s += " AS " + e.Alias
575+
elemStr += " AS " + e.Alias
576576
}
577-
elems[i] = s
577+
elems[i] = elemStr
578578
}
579579
sb.WriteString(strings.Join(elems, ", "))
580580
}

0 commit comments

Comments
 (0)