[EME] Check support for full content type (including codecs)

https://bugs.webkit.org/show_bug.cgi?id=310709

Reviewed by Jer Noble and Xabier Rodriguez-Calvar.

When evaluating media capabilities for requestMediaKeySystemAccess,
we use pass ParsedContentType's m_mimeType to the MediaSource,
which omits parameters of the MIME type like codecs.

The right field to use here is m_contentType, so MediaSource
can check support against the full MIME type, rather than just
its container type.

* LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess-expected.txt:
* LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html: Add test with supported type but unknown codec.
* LayoutTests/platform/glib/TestExpectations: Unflag mock-navigator-requestMediaKeySystemAccess.html.
* LayoutTests/platform/ios/TestExpectations: Ditto.
* LayoutTests/platform/mac/TestExpectations: Ditto.
* Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp:
(WebCore::CDMPrivate::getSupportedCapabilitiesForAudioVideoType): Use full contentType for MediaEngineSupportParameters.
* Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::supportsType): Return NotSupported if codec is 'unknown' or 'invalid'.
* Source/WebCore/platform/network/ParsedContentType.h:
(WebCore::ParsedContentType::contentType const): Added, returns m_contentType.

Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com>

See: #1643
Canonical link: https://commits.webkit.org/310696@main

Author: vivienne-w

LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess-expected.txt

@@ -13,6 +13,11 @@ EXPECTED (access.getConfiguration().sessionTypes[0] == 'temporary') OK
 EXPECTED (access.getConfiguration().distinctiveIdentifier == 'not-allowed') OK
 EXPECTED (access.getConfiguration().persistentState == 'not-allowed') OK
 
+SET capabilities = '[ { "initDataTypes": [ "mock" ], "videoCapabilities": [ { "contentType": "video/mock; codecs=\"unknown\"" } ] } ]'
+RUN(promise = navigator.requestMediaKeySystemAccess("org.webkit.mock", capabilities))
+Promise rejected correctly OK
+EXPECTED (exceptionCode.name == 'NotSupportedError') OK
+
 SET capabilities = '[ { "initDataTypes": [ "mock" ], "videoCapabilities": [ { "contentType": "unknown/mime; codecs=\"unknown\"" } ] } ]'
 RUN(promise = navigator.requestMediaKeySystemAccess("org.webkit.mock", capabilities))
 Promise rejected correctly OK

LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html

@@ -66,6 +66,17 @@
                 });
         },
 
+        function() {
+            failingTestWithCapabilities([{
+                    initDataTypes: ['mock'],
+                    videoCapabilities: [{ contentType: 'video/mock; codecs="unknown"' }]
+                }],
+                exceptionCode => {
+                    window.exceptionCode = exceptionCode;
+                    testExpected('exceptionCode.name', 'NotSupportedError');
+                });
+        },
+
         function() {
             failingTestWithCapabilities([{
                     initDataTypes: ['mock'],

LayoutTests/platform/glib/TestExpectations

@@ -2597,7 +2597,6 @@ webkit.org/b/189345 http/tests/media/clearkey/collect-webkit-media-session.html
 
 media/encrypted-media [ Pass ]
 
-webkit.org/b/205857 media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html [ Skip ]
 webkit.org/b/205860 media/encrypted-media/mock-MediaKeySession-remove.html [ Skip ]
 
 webkit.org/b/251550 media/encrypted-media/mock-MediaKeySession-generateRequest.html [ Crash Pass ]

LayoutTests/platform/ios/TestExpectations

@@ -2727,9 +2727,6 @@ webkit.org/b/245610 http/tests/security/xss-DENIED-xsl-external-entity.xml [ Fai
 # Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
 fast/forms/validation-message-minimum-font-size.html [ Skip ]
 
-# New Encrypted Media API not enabled on iOS
-media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html [ Skip ]
-
 webkit.org/b/166736 fast/scrolling/page-cache-back-overflow-scroll-restore.html [ Skip ]
 
 # Requires changes to QuickLook.framework tracked by rdar://problem/28544527

LayoutTests/platform/mac/TestExpectations

@@ -1118,7 +1118,6 @@ webkit.org/b/165530 compositing/layer-creation/fixed-position-out-of-view-scaled
 webkit.org/b/165874 streams/pipe-to.html [ Pass Failure ]
 
 # New Encrypted Media API not enabled on Mac
-media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html [ Skip ]
 media/encrypted-media/mock-MediaKeySystemAccess.html [ Skip ]
 media/encrypted-media/mock-MediaKeys-setServerCertificate.html [ Skip ]
 media/encrypted-media/mock-MediaKeys-createSession.html [ Skip ]

Source/WebCore/platform/encryptedmedia/CDMPrivate.cpp

@@ -420,7 +420,7 @@ std::optional<Vector<CDMMediaCapability>> CDMPrivate::getSupportedCapabilitiesFo
         //       combination of container, media types, robustness and local accumulated configuration in combination
         //       with restrictions:
         MediaEngineSupportParameters parameters;
-        parameters.type = ContentType(contentType->mimeType());
+        parameters.type = ContentType(contentType->contentType());
         if (MediaPlayer::supportsType(parameters) == MediaPlayer::SupportsType::IsNotSupported) {
 
             // Try with Media Source:

Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp

@@ -94,6 +94,9 @@ MediaPlayer::SupportsType MockMediaPlayerMediaSource::supportsType(const MediaEn
     if (codecs == "mock"_s || codecs == "kcom"_s)
         return MediaPlayer::SupportsType::IsSupported;
 
+    if (codecs == "unknown"_s || codecs == "invalid"_s)
+        return MediaPlayer::SupportsType::IsNotSupported;
+
     return MediaPlayer::SupportsType::MayBeSupported;
 }
 

Source/WebCore/platform/network/ParsedContentType.h

@@ -49,6 +49,7 @@ class ParsedContentType {
     ParsedContentType(ParsedContentType&&) = default;
 
     String mimeType() const { return m_mimeType; }
+    String contentType() const { return m_contentType; }
     String charset() const;
     void setCharset(String&&);