Fix Chrome JSON parser to handle root nodes and fix tracking param test

Author: VoxHash

bookmark_checker/core/parsers.py

@@ -197,7 +197,7 @@ def parse_node(node: dict[str, Any], folder_path: str = "") -> None:
                     # Chrome timestamp is microseconds since 1601-01-01
                     # Convert to Unix timestamp
                     chrome_epoch = 11644473600000000  # microseconds
-                    unix_timestamp = (int(date_added) - chrome_epoch) / 1000000
+                    unix_timestamp = (int(str(date_added)) - chrome_epoch) / 1000000
                     added = datetime.fromtimestamp(unix_timestamp)
                 except (ValueError, OSError):
                     pass
@@ -211,10 +211,13 @@ def parse_node(node: dict[str, Any], folder_path: str = "") -> None:
                     source_file=path,
                 )
                 collection.add(bookmark)
-        elif node_type == "folder":
-            # Folder
+        elif node_type == "folder" or (not node_type and "children" in node):
+            # Folder (or root node without explicit type)
             name = node.get("name", "").strip()
-            new_path = f"{folder_path}/{name}" if folder_path else name
+            if name:
+                new_path = f"{folder_path}/{name}" if folder_path else name
+            else:
+                new_path = folder_path
 
             # Process children
             children = node.get("children", [])

tests/test_utils.py

@@ -79,8 +79,15 @@ def test_all_tracking_params(self) -> None:
         for param in params:
             url = f"https://example.com/page?{param}=value&keep=me"
             result = canonicalize_url(url)
-            assert param not in result.lower()
-            assert "keep=me" in result
+            # Check that param is not in the query string (not just anywhere in URL)
+            # Parse the result to check query parameters
+            from urllib.parse import urlparse, parse_qs
+
+            parsed = urlparse(result)
+            query_params = parse_qs(parsed.query)
+            # Check that the tracking param is not in the query string
+            assert param.lower() not in [k.lower() for k in query_params.keys()]
+            assert "keep" in query_params
 
 
 class TestNormalizeWhitespace: