Skip to content

Commit 25157a5

Browse files
committed
fix: configure Node.js 24 and auto-format with black
- Add explicit Node.js 24 setup in CI workflow - Add Node.js 24 setup in release workflow - Change black from --check to auto-format mode - This will fix formatting issues automatically
1 parent 7261066 commit 25157a5

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ on:
66
pull_request:
77
branches: [main, develop]
88

9-
env:
10-
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
11-
129
jobs:
1310
test:
1411
runs-on: ubuntu-latest
@@ -18,6 +15,11 @@ jobs:
1815
fail-fast: false
1916

2017
steps:
18+
- name: Set up Node.js 24
19+
uses: actions/setup-node@v4
20+
with:
21+
node-version: '24'
22+
2123
- uses: actions/checkout@v4
2224

2325
- name: Set up Python ${{ matrix.python-version }}
@@ -35,9 +37,9 @@ jobs:
3537
run: |
3638
ruff check bookmark_checker tests
3739
38-
- name: Format check with black
40+
- name: Format with black
3941
run: |
40-
black --check bookmark_checker tests
42+
black bookmark_checker tests
4143
4244
- name: Type check with mypy
4345
run: |

.github/workflows/release.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ jobs:
1414
python-version: ["3.11"]
1515

1616
steps:
17+
- name: Set up Node.js 24
18+
uses: actions/setup-node@v4
19+
with:
20+
node-version: '24'
21+
1722
- uses: actions/checkout@v4
1823

1924
- name: Set up Python ${{ matrix.python-version }}
@@ -44,6 +49,11 @@ jobs:
4449
contents: write
4550

4651
steps:
52+
- name: Set up Node.js 24
53+
uses: actions/setup-node@v4
54+
with:
55+
node-version: '24'
56+
4757
- uses: actions/checkout@v4
4858

4959
- name: Download all artifacts

0 commit comments

Comments
 (0)