Skip to content

Text search does not work for the last item in a folder #4039

@Metamere

Description

@Metamere

Please describe the problem:

When you use the alphanumeric text input search method, it is unable to find the last file in any folder. If the last files in a folder are Vibraphone, Wurlitzer, and Xylophone, then you get results for V or W, but not X. If a folder is then added in the last position of the folder's contents alphabetically (for example a folder named Zeta), then it can find the last file that was previously unsearchable, but now the new folder will be unsearchable.

What is the expected behavior?

It should be able to find any file or folder within a folder by typing in its filename using the text search feature.

When did you start noticing the issue?

I discovered the bug yesterday, while testing to make sure that the text search feature still worked properly with my refactor of the file browser code. I thought it must have been something I caused, but it turned out to have been a bug for years, in all of the releases since 1.0. It was not an issue in the first commit in the repository fresh from Synthstrom, so sometime in the development work towards 1.0 the bug was introduced.

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Release 1.0/Amadeus

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

  • Go into a file browser menu for a synth, kit, etc.
  • Find the last file in the folder, then scroll back up. Try typing the first letters of the last file's name, and it will not show up. Compare by typing the first letters of a different file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions