Merge pull request #393 from RtlZeroMemory/fix/windows-create-rezi-debug

fix(create-rezi): harden windows scaffold installs

Author: RtlZeroMemory

CHANGELOG.md

@@ -6,6 +6,11 @@ The format is based on Keep a Changelog and the project follows Semantic Version
 
 ## [Unreleased]
 
+### Bug Fixes
+
+- **create-rezi/cli**: Fixed Windows nested installs by switching `create-rezi` to the standard `cross-spawn` process launcher and by resolving npm installs through the active npm entrypoint instead of relying on Git Bash shell resolution.
+- **create-rezi/minimal**: Replaced the invalid bare `+` keybinding in the minimal template with Windows-safe `=` / `shift+=` bindings while keeping `+` as an accepted command alias.
+
 ## [0.1.0-alpha.68] - 2026-04-15
 
 ### CI / Tooling

package-lock.json

@@ -22,6 +22,10 @@
     "bun": ">=1.3.0"
   },
   "devDependencies": {
-    "@rezi-ui/testkit": "0.1.0-alpha.61"
+    "@rezi-ui/testkit": "0.1.0-alpha.61",
+    "@types/cross-spawn": "^6.0.6"
+  },
+  "dependencies": {
+    "cross-spawn": "^7.0.6"
   }
 }

packages/create-rezi/package.json

@@ -1,6 +1,9 @@
 import { resolve } from "node:path";
 import { assert, test } from "@rezi-ui/testkit";
-import { createInstallEnv, resolveInstallCwd } from "../index.js";
+import { createInstallEnv, resolveInstallCwd, resolveInstallInvocation } from "../index.js";
+
+const WINDOWS_ROAMING_NPM_EXEC_PATH =
+  "C:\\Users\\example\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js";
 
 test("resolveInstallCwd resolves targetDir against the current base directory", () => {
   assert.equal(
@@ -53,3 +56,58 @@ test("createInstallEnv strips parent npm lifecycle metadata but preserves useful
   assert.equal(childEnv.npm_package_name, undefined);
   assert.equal(childEnv.npm_package_json, undefined);
 });
+
+test("resolveInstallInvocation prefers npm_execpath and falls back to node-adjacent npm.cmd on Windows", () => {
+  assert.deepEqual(
+    resolveInstallInvocation("npm", {
+      env: {
+        npm_execpath: WINDOWS_ROAMING_NPM_EXEC_PATH,
+      },
+      platform: "win32",
+      nodeExecPath: "C:\\Program Files\\nodejs\\node.exe",
+    }),
+    {
+      command: "C:\\Program Files\\nodejs\\node.exe",
+      args: [WINDOWS_ROAMING_NPM_EXEC_PATH, "install"],
+    },
+  );
+
+  assert.deepEqual(
+    resolveInstallInvocation("npm", {
+      env: {
+        npm_execpath:
+          "C:\\Users\\example\\AppData\\Roaming\\npm\\node_modules\\pnpm\\bin\\pnpm.cjs",
+      },
+      platform: "win32",
+      nodeExecPath: "C:\\Program Files\\nodejs\\node.exe",
+    }),
+    {
+      command: "C:\\Program Files\\nodejs\\npm.cmd",
+      args: ["install"],
+    },
+  );
+
+  assert.deepEqual(
+    resolveInstallInvocation("npm", {
+      env: {},
+      platform: "win32",
+      nodeExecPath: "C:\\Program Files\\nodejs\\node.exe",
+    }),
+    {
+      command: "C:\\Program Files\\nodejs\\npm.cmd",
+      args: ["install"],
+    },
+  );
+
+  assert.deepEqual(
+    resolveInstallInvocation("pnpm", {
+      env: {},
+      platform: "win32",
+      nodeExecPath: "C:\\Program Files\\nodejs\\node.exe",
+    }),
+    {
+      command: "pnpm",
+      args: ["install"],
+    },
+  );
+});

packages/create-rezi/src/__tests__/index.test.ts

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
-import { spawnSync } from "node:child_process";
-import { relative, resolve } from "node:path";
+import { dirname, join, relative, resolve, win32 } from "node:path";
 import { cwd, exit, stdin, stdout } from "node:process";
 import { createInterface } from "node:readline/promises";
+import * as crossSpawn from "cross-spawn";
 import { isMainModuleEntry } from "./mainEntry.js";
 import {
   TEMPLATE_DEFINITIONS,
@@ -149,6 +149,15 @@ function shouldStripInstallEnvKey(key: string): boolean {
   );
 }
 
+function isNpmExecPath(execPath: string): boolean {
+  const normalized = execPath.replaceAll("\\", "/").toLowerCase();
+  return (
+    normalized.endsWith("/npm-cli.js") ||
+    normalized.endsWith("/npm-cli.mjs") ||
+    /(^|\/)npm(\.cmd|\.exe)?$/.test(normalized)
+  );
+}
+
 export function createInstallEnv(
   parentEnv: Readonly<Record<string, string | undefined>> = process.env,
 ): NodeJS.ProcessEnv {
@@ -165,6 +174,32 @@ export function resolveInstallCwd(targetDir: string, baseDir: string = cwd()): s
   return resolve(baseDir, targetDir);
 }
 
+export function resolveInstallInvocation(
+  packageManager: PackageManager,
+  {
+    env = process.env,
+    platform = process.platform,
+    nodeExecPath = process.execPath,
+  }: {
+    env?: Readonly<Record<string, string | undefined>>;
+    platform?: NodeJS.Platform;
+    nodeExecPath?: string;
+  } = {},
+): { command: string; args: string[] } {
+  if (packageManager === "npm") {
+    // biome-ignore lint/complexity/useLiteralKeys: process.env-compatible maps use index signatures in TS.
+    const npmExecPath = env["npm_execpath"];
+    if (npmExecPath && isNpmExecPath(npmExecPath)) {
+      return { command: nodeExecPath, args: [npmExecPath, "install"] };
+    }
+    if (platform === "win32") {
+      return { command: win32.join(win32.dirname(nodeExecPath), "npm.cmd"), args: ["install"] };
+    }
+  }
+
+  return { command: packageManager, args: ["install"] };
+}
+
 async function promptText(
   rl: ReturnType<typeof createInterface>,
   prompt: string,
@@ -200,7 +235,8 @@ async function promptTemplate(rl: ReturnType<typeof createInterface>): Promise<s
 
 function runInstall(pm: PackageManager, targetDir: string): void {
   const installCwd = resolveInstallCwd(targetDir);
-  const res = spawnSync(pm, ["install"], {
+  const installInvocation = resolveInstallInvocation(pm);
+  const res = crossSpawn.sync(installInvocation.command, installInvocation.args, {
     cwd: installCwd,
     stdio: "inherit",
     env: createInstallEnv(),

packages/create-rezi/src/index.ts

@@ -4,6 +4,7 @@ import { resolveMinimalCommand } from "../helpers/keybindings.js";
 
 test("minimal keybinding map resolves expected commands", () => {
   assert.equal(resolveMinimalCommand("q"), "quit");
+  assert.equal(resolveMinimalCommand("="), "increment");
   assert.equal(resolveMinimalCommand("+"), "increment");
   assert.equal(resolveMinimalCommand("-"), "decrement");
   assert.equal(resolveMinimalCommand("t"), "cycle-theme");

packages/create-rezi/templates/minimal/src/__tests__/keybindings.test.ts

@@ -11,6 +11,7 @@ const COMMAND_BY_KEY: Readonly<Record<string, MinimalCommand>> = Object.freeze({
   "ctrl+c": "quit",
   h: "toggle-help",
   "shift+/": "toggle-help",
+  "=": "increment",
   "+": "increment",
   "shift+=": "increment",
   "-": "decrement",

packages/create-rezi/templates/minimal/src/helpers/keybindings.ts

@@ -125,7 +125,7 @@ app.keys({
   "ctrl+c": () => applyCommand(resolveMinimalCommand("ctrl+c")),
   h: () => applyCommand(resolveMinimalCommand("h")),
   "shift+/": () => applyCommand(resolveMinimalCommand("shift+/")),
-  "+": () => applyCommand(resolveMinimalCommand("+")),
+  "=": () => applyCommand(resolveMinimalCommand("=")),
   "shift+=": () => applyCommand(resolveMinimalCommand("shift+=")),
   "-": () => applyCommand(resolveMinimalCommand("-")),
   t: () => applyCommand(resolveMinimalCommand("t")),