Skip to content

Commit b19db88

Browse files
committed
test case changes and minor fixes
1 parent 50463fd commit b19db88

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

src/rush/card/reset_card.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,10 @@ def get_remaining_min(self, date_to_check_against: DateTime = None) -> Decimal:
171171
CardEmis.payment_status == "UnPaid",
172172
)
173173

174-
if date_to_check_against:
175-
current_date = get_current_ist_time().date()
176-
final_date = current_date if current_date < date_to_check_against else date_to_check_against
177-
query = query.filter(CardEmis.due_date <= final_date)
174+
if not date_to_check_against:
175+
date_to_check_against = get_current_ist_time().date()
176+
177+
query = query.filter(CardEmis.due_date <= date_to_check_against)
178178

179179
unpaid_emis = query.all()
180180
remaining_min_of_all_emis = sum(emi.total_due_amount for emi in unpaid_emis)

src/rush/create_emi.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44

55
from dateutil.relativedelta import relativedelta
66
from pendulum import DateTime
7-
from sqlalchemy import (
8-
and_,
9-
or_,
10-
)
117
from sqlalchemy.orm import (
128
Session,
139
aliased,

src/test/test_reset_card.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_create_term_loan(session: Session) -> None:
148148
assert emis_dict[-1]["total_due_amount"] % 10 == 0
149149

150150
min_amount = user_loan.get_remaining_min(date_to_check_against=parse_date("2020-11-01").date())
151-
assert min_amount == Decimal("1140")
151+
assert min_amount == Decimal("3420")
152152

153153
max_amount = user_loan.get_remaining_max()
154154
assert max_amount == Decimal("13680")

0 commit comments

Comments
 (0)