Merge pull request #144 from RedCarpetUp/loan_id_migration

fixes for bulk_insert and loan_id not null

Author: transhapHigsn

src/rush/models.py

@@ -543,7 +543,7 @@ class PaymentSplit(AuditMixin):
     payment_request_id = Column(String(), nullable=False, index=True)
     component = Column(String(50), nullable=False)
     amount_settled = Column(Numeric, nullable=False)
-    loan_id = Column(Integer, ForeignKey(Loan.id), nullable=False)
+    loan_id = Column(Integer, ForeignKey(Loan.id), nullable=True)
 
 
 class LoanMoratorium(AuditMixin):

src/rush/payments.py

@@ -408,11 +408,13 @@ def create_payment_split(session: Session, event: LedgerTriggerEvent):
     split_data = get_payment_split_from_event(session, event)
     new_ps_objects = []
     for component, amount in split_data.items():
-        ps = PaymentSplit(
-            payment_request_id=event.extra_details["payment_request_id"],
-            component=component,
-            amount_settled=amount,
-            loan_id=event.loan_id,
+        new_ps_objects.append(
+            {
+                "payment_request_id": event.extra_details["payment_request_id"],
+                "component": component,
+                "amount_settled": amount,
+                "loan_id": event.loan_id,
+            }
         )
-        new_ps_objects.append(ps)
-    session.bulk_save_objects(new_ps_objects)
+
+    session.bulk_insert_mappings(PaymentSplit, new_ps_objects)

src/test/alembic_config/versions/e2467923fab_loan_schedule.py

@@ -66,7 +66,9 @@ def upgrade() -> None:
         sa.Column("payment_request_id", sa.String(), nullable=False, index=True),
         sa.Column("component", sa.String(50), nullable=False),
         sa.Column("amount_settled", sa.DECIMAL(), nullable=False),
-        sa.Column("loan_id", sa.Integer(), nullable=False),
+        sa.Column(
+            "loan_id", sa.Integer(), nullable=True
+        ),  # this will be fixed later, doing this for testing purposes.
         sa.Column("created_at", sa.TIMESTAMP(), nullable=False),
         sa.Column("updated_at", sa.TIMESTAMP(), nullable=False),
         sa.Column("performed_by", sa.Integer(), nullable=False),