avoid .Any() on hot paths

This allocates an enumerator unnecessarily if we already have the count available.

Author: Pathoschild

src/SMAPI/Framework/ContentCoordinator.cs

@@ -366,7 +366,7 @@ public T LoadManagedAsset<T>(string contentManagerId, IAssetName relativePath)
     /// <param name="predicate">Matches the asset keys to invalidate.</param>
     /// <param name="dispose">Whether to dispose invalidated assets. This should only be <c>true</c> when they're being invalidated as part of a dispose, to avoid crashing the game.</param>
     /// <returns>Returns the invalidated asset keys.</returns>
-    public IEnumerable<IAssetName> InvalidateCache(Func<IAssetInfo, bool> predicate, bool dispose = false)
+    public ICollection<IAssetName> InvalidateCache(Func<IAssetInfo, bool> predicate, bool dispose = false)
     {
         string locale = this.GetLocale();
         return this.InvalidateCache((_, rawName, type) =>
@@ -381,7 +381,7 @@ public IEnumerable<IAssetName> InvalidateCache(Func<IAssetInfo, bool> predicate,
     /// <param name="predicate">Matches the asset keys to invalidate.</param>
     /// <param name="dispose">Whether to dispose invalidated assets. This should only be <c>true</c> when they're being invalidated as part of a dispose, to avoid crashing the game.</param>
     /// <returns>Returns the invalidated asset names.</returns>
-    public IEnumerable<IAssetName> InvalidateCache(Func<IContentManager, string, Type, bool> predicate, bool dispose = false)
+    public ICollection<IAssetName> InvalidateCache(Func<IContentManager, string, Type, bool> predicate, bool dispose = false)
     {
         // invalidate cache & track removed assets
         IDictionary<IAssetName, Type> invalidatedAssets = new Dictionary<IAssetName, Type>();
@@ -438,7 +438,7 @@ public IEnumerable<IAssetName> InvalidateCache(Func<IContentManager, string, Typ
         });
 
         // handle invalidation
-        if (invalidatedAssets.Any())
+        if (invalidatedAssets.Count > 0)
         {
             // clear cached editor checks
             foreach (IAssetName name in invalidatedAssets.Keys)

src/SMAPI/Framework/Deprecations/DeprecationManager.cs

@@ -94,7 +94,7 @@ public void PlaceholderWarn(string version, DeprecationLevel severity) { }
     /// <summary>Print any queued messages.</summary>
     public void PrintQueued()
     {
-        if (!this.QueuedWarnings.Any())
+        if (this.QueuedWarnings.Count == 0)
             return;
 
         foreach (DeprecationWarning warning in this.QueuedWarnings.OrderBy(p => p.ModName).ThenBy(p => p.NounPhrase))
@@ -149,7 +149,7 @@ public void PrintQueued()
     /// <param name="unlessStackIncludes">A list of stack trace substrings which should suppress deprecation warnings if they appear in the stack trace.</param>
     private bool ShouldSuppress(ImmutableStackTrace stack, string[]? unlessStackIncludes)
     {
-        if (unlessStackIncludes?.Any() == true)
+        if (unlessStackIncludes is { Length: > 0 })
         {
             string stackTrace = stack.ToString();
             foreach (string method in unlessStackIncludes)

src/SMAPI/Framework/Input/SInputState.cs

@@ -271,11 +271,11 @@ private bool ApplyOverrides(ISet<SButton> pressed, ISet<SButton> released, GameP
         }
 
         // override states
-        if (keyboardOverrides.Any())
+        if (keyboardOverrides.Count > 0)
             keyboard.OverrideButtons(keyboardOverrides);
-        if (controllerOverrides.Any())
+        if (controllerOverrides.Count > 0)
             controller.OverrideButtons(controllerOverrides);
-        if (mouseOverrides.Any())
+        if (mouseOverrides.Count > 0)
             mouse.OverrideButtons(mouseOverrides);
 
         return true;

src/SMAPI/Framework/ModHelpers/GameContentHelper.cs

@@ -107,22 +107,22 @@ public bool InvalidateCache(string key)
     public bool InvalidateCache(IAssetName assetName)
     {
         this.Monitor.Log($"Requested cache invalidation for '{assetName}'.");
-        return this.ContentCore.InvalidateCache(asset => asset.Name.IsEquivalentTo(assetName)).Any();
+        return this.ContentCore.InvalidateCache(asset => asset.Name.IsEquivalentTo(assetName)).Count > 0;
     }
 
     /// <inheritdoc />
     public bool InvalidateCache<T>()
         where T : notnull
     {
         this.Monitor.Log($"Requested cache invalidation for all assets of type {typeof(T)}. This is an expensive operation and should be avoided if possible.");
-        return this.ContentCore.InvalidateCache((_, _, type) => typeof(T).IsAssignableFrom(type)).Any();
+        return this.ContentCore.InvalidateCache((_, _, type) => typeof(T).IsAssignableFrom(type)).Count > 0;
     }
 
     /// <inheritdoc />
     public bool InvalidateCache(Func<IAssetInfo, bool> predicate)
     {
         this.Monitor.Log("Requested cache invalidation for all assets matching a predicate.");
-        return this.ContentCore.InvalidateCache(predicate).Any();
+        return this.ContentCore.InvalidateCache(predicate).Count > 0;
     }
 
     /// <inheritdoc />

src/SMAPI/Framework/ModLoading/AssemblyLoader.cs

@@ -123,7 +123,7 @@ select name
         }
 
         // validate load
-        if (!assemblies.Any() || assemblies[0].Status == AssemblyLoadStatus.Failed)
+        if (assemblies.Length == 0 || assemblies[0].Status == AssemblyLoadStatus.Failed)
         {
             throw new SAssemblyLoadFailedException(!assemblyFile.Exists
                 ? $"Could not load '{assemblyFile.FullName}' because it doesn't exist."
@@ -475,7 +475,7 @@ private void ProcessInstructionHandleResult(IModMetadata mod, IInstructionHandle
 
         // format messages
         string phrase;
-        if (!handler.Phrases.Any())
+        if (handler.Phrases.Count == 0)
             phrase = handler.DefaultPhrase;
         else if (this.LogTechnicalDetailsForBrokenMods && result == InstructionHandleResult.NotCompatible)
             phrase = "\n - " + string.Join(";\n - ", handler.Phrases.OrderBy(p => p, StringComparer.OrdinalIgnoreCase));

src/SMAPI/Framework/ModLoading/Finders/EventFinder.cs

@@ -53,7 +53,7 @@ public EventFinder(string fullTypeName, string eventName, InstructionHandleResul
     /// <inheritdoc />
     public override bool Handle(ModuleDefinition module, ILProcessor cil, Instruction instruction)
     {
-        if (this.MethodNames.Any())
+        if (this.MethodNames.Count > 0)
         {
             MethodReference? methodRef = RewriteHelper.AsMethodReference(instruction);
             if (methodRef != null && methodRef.DeclaringType.FullName == this.FullTypeName && this.MethodNames.Contains(methodRef.Name))

src/SMAPI/Framework/ModLoading/Finders/FieldFinder.cs

@@ -47,7 +47,7 @@ public FieldFinder(string fullTypeName, string fieldName, InstructionHandleResul
     /// <inheritdoc />
     public override bool Handle(ModuleDefinition module, ILProcessor cil, Instruction instruction)
     {
-        if (this.FieldNames.Any())
+        if (this.FieldNames.Count > 0)
         {
             FieldReference? fieldRef = RewriteHelper.AsFieldReference(instruction);
             if (fieldRef != null && fieldRef.DeclaringType.FullName == this.FullTypeName && this.FieldNames.Contains(fieldRef.Name))

src/SMAPI/Framework/ModLoading/Finders/ReferenceToInvalidMemberFinder.cs

@@ -64,7 +64,7 @@ public override bool Handle(ModuleDefinition module, ILProcessor cil, Instructio
             if (methodDef != null && this.ShouldValidate(methodRef.DeclaringType))
             {
                 MethodDefinition[]? candidateMethods = methodRef.DeclaringType.Resolve()?.Methods.Where(found => found.Name == methodRef.Name).ToArray();
-                if (candidateMethods?.Any() is true && candidateMethods.All(method => !RewriteHelper.LooksLikeSameType(method.ReturnType, methodDef.ReturnType)))
+                if (candidateMethods is { Length: > 0 } && candidateMethods.All(method => !RewriteHelper.LooksLikeSameType(method.ReturnType, methodDef.ReturnType)))
                     this.MarkFlag(InstructionHandleResult.NotCompatible, $"reference to {this.GetMemberDisplayName(methodDef)} (no such method returns {this.GetFriendlyTypeName(methodDef.ReturnType)})");
             }
 

src/SMAPI/Framework/ModLoading/ModResolver.cs

@@ -192,7 +192,7 @@ public void ValidateManifests(IEnumerable<IModMetadata> mods, ISemanticVersion a
     /// <param name="modIdsToLoadLate">The mod IDs SMAPI should load after any other mods.</param>
     public IModMetadata[] ApplyLoadOrderOverrides(IModMetadata[] mods, HashSet<string> modIdsToLoadEarly, HashSet<string> modIdsToLoadLate)
     {
-        if (!modIdsToLoadEarly.Any() && !modIdsToLoadLate.Any())
+        if (modIdsToLoadEarly.Count == 0 && modIdsToLoadLate.Count == 0)
             return mods;
 
         string[] earlyArray = modIdsToLoadEarly.ToArray();
@@ -283,7 +283,7 @@ private ModDependencyStatus ProcessDependencies(IReadOnlyList<IModMetadata> mods
         ModDependency[] dependencies = this.GetDependenciesFrom(mod.Manifest, mods).ToArray();
 
         // mark sorted if no dependencies
-        if (!dependencies.Any())
+        if (dependencies.Length == 0)
         {
             sortedMods.Push(mod);
             return states[mod] = ModDependencyStatus.Sorted;
@@ -306,7 +306,7 @@ orderby displayName
                     ? $"{displayName}: {modUrl}"
                     : displayName
             ).ToArray();
-            if (failedModNames.Any())
+            if (failedModNames.Length > 0)
             {
                 sortedMods.Push(mod);
                 mod.SetStatus(ModMetadataStatus.Failed, ModFailReason.MissingDependencies, $"it requires mods which aren't installed ({string.Join(", ", failedModNames)}).");
@@ -325,7 +325,7 @@ from entry in dependencies
                     select $"{entry.Mod!.DisplayName} (needs {entry.MinVersion} or later)"
                 )
                 .ToArray();
-            if (failedLabels.Any())
+            if (failedLabels.Length > 0)
             {
                 sortedMods.Push(mod);
                 mod.SetStatus(ModMetadataStatus.Failed, ModFailReason.MissingDependencies, $"it needs newer versions of some mods: {string.Join(", ", failedLabels)}.");
@@ -430,7 +430,7 @@ private IEnumerable<ModDependency> GetDependenciesFrom(IManifest manifest, IRead
             $"marked {statusLabel} in SMAPI's internal compatibility list for "
             + (data.StatusUpperVersion != null ? $"versions up to {data.StatusUpperVersion}" : "all versions")
             + ": "
-            + (reasons.Any() ? string.Join(": ", reasons) : "no reason given")
+            + (reasons.Length > 0 ? string.Join(": ", reasons) : "no reason given")
             + ".";
     }
 

src/SMAPI/Framework/ModLoading/TypeReferenceComparer.cs

@@ -112,7 +112,7 @@ private IEnumerable<string> GetTypeSymbols(string typeName)
 
         Queue<char> queue = new(typeName);
         string symbol = "";
-        while (queue.Any())
+        while (queue.Count > 0)
         {
             char ch = queue.Dequeue();
             switch (ch)