Skip to content

Commit 722e9de

Browse files
author
Googler
committed
Upgrade to the latest version of the "marked" TS/JS library.
PiperOrigin-RevId: 867626088
1 parent 126dd9e commit 722e9de

3 files changed

Lines changed: 14 additions & 18 deletions

File tree

lit_nlp/client/lib/utils.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import * as d3 from 'd3'; // Used for array helpers.
2626
import {unsafeHTML} from 'lit/directives/unsafe-html.js';
2727

28-
import {marked} from 'marked';
28+
import {Marked, Renderer, Tokens} from 'marked';
2929
import {LIT_TYPES_REGISTRY, LitName, LitType, LitTypeTypesList, LitTypeWithParent, MulticlassPreds} from './lit_types';
3030
import {CallConfig, FacetMap, IndexedInput, ModelInfoMap, Spec} from './types';
3131

@@ -527,13 +527,15 @@ export function getTemplateStringFromMarkdown(markdown: string) {
527527
// Render Markdown with link target _blank
528528
// See https://github.com/markedjs/marked/issues/144
529529
// and https://github.com/markedjs/marked/issues/655
530-
const renderer = new marked.Renderer();
531-
renderer.link = (href, title, text) => {
532-
const linkHtml =
533-
marked.Renderer.prototype.link.call(renderer, href, title, text);
534-
return linkHtml.replace('<a', '<a target=\'_blank\' ');
530+
const renderer = new Renderer();
531+
renderer.link = function(this: Renderer, token: Tokens.Link): string {
532+
const output = Renderer.prototype.link.call(this, token);
533+
return output.replace(
534+
/^<a /,
535+
'<a target="_blank" rel="noopener noreferrer" ',
536+
);
535537
};
536-
const htmlStr = marked(markdown, {renderer});
538+
const htmlStr = new Marked().use({renderer}).parse(markdown, {async: false});
537539

538540
return unsafeHTML(htmlStr);
539541
}

lit_nlp/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"d3": "5.16.0",
2828
"difflib": "0.2.4",
2929
"lit": "2.7.6",
30-
"marked": "5.1.2",
30+
"marked": "17.0.1",
3131
"megaplot": "github:PAIR-code/megaplot#ca8210d",
3232
"mobx": "6.1.8",
3333
"node-polyfill-webpack-plugin": "^2.0.1",
@@ -40,7 +40,6 @@
4040
"@types/difflib": "0.2.0",
4141
"@types/eslint": "8.44.1",
4242
"@types/jasmine": "3.5.10",
43-
"@types/marked": "5.0.1",
4443
"@types/node": "20.4.5",
4544
"@types/resize-observer-browser": "0.1.7",
4645
"@types/seedrandom": "3.0.5",

lit_nlp/yarn.lock

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -938,11 +938,6 @@
938938
resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.12.tgz#d70faba7039d5fca54c83c7dbab41051d2b6f6cb"
939939
integrity sha512-Hr5Jfhc9eYOQNPYO5WLDq/n4jqijdHNlDXjuAQkkt+mWdQR+XJToOHrsD4cPaMXpn6KO7y2+wM8AZEs8VpBLVA==
940940

941-
"@types/marked@5.0.1":
942-
version "5.0.1"
943-
resolved "https://registry.yarnpkg.com/@types/marked/-/marked-5.0.1.tgz#15acd796d722b91bf00738c8c8539aaf5034f0c6"
944-
integrity sha512-Y3pAUzHKh605fN6fvASsz5FDSWbZcs/65Q6xYRmnIP9ZIYz27T4IOmXfH9gWJV1dpi7f1e7z7nBGUTx/a0ptpA==
945-
946941
"@types/mime@*":
947942
version "3.0.1"
948943
resolved "https://registry.yarnpkg.com/@types/mime/-/mime-3.0.1.tgz#5f8f2bca0a5863cb69bc0b0acd88c96cb1d4ae10"
@@ -3465,10 +3460,10 @@ lru-cache@^6.0.0:
34653460
dependencies:
34663461
yallist "^4.0.0"
34673462

3468-
marked@5.1.2:
3469-
version "5.1.2"
3470-
resolved "https://registry.yarnpkg.com/marked/-/marked-5.1.2.tgz#62b5ccfc75adf72ca3b64b2879b551d89e77677f"
3471-
integrity sha512-ahRPGXJpjMjwSOlBoTMZAK7ATXkli5qCPxZ21TG44rx1KEo44bii4ekgTDQPNRQ4Kh7JMb9Ub1PVk1NxRSsorg==
3463+
marked@17.0.1:
3464+
version "17.0.1"
3465+
resolved "https://registry.yarnpkg.com/marked/-/marked-17.0.1.tgz#9db34197ac145e5929572ee49ef701e37ee9b2e6"
3466+
integrity sha512-boeBdiS0ghpWcSwoNm/jJBwdpFaMnZWRzjA6SkUMYb40SVaN1x7mmfGKp0jvexGcx+7y2La5zRZsYFZI6Qpypg==
34723467

34733468
md5.js@^1.3.4:
34743469
version "1.3.5"

0 commit comments

Comments
 (0)