Skip to content

Commit 1d99de8

Browse files
gpetrouslozier
gpetrou
authored and
slozier
committed
Add FxCopAnalyzers (#600)
1 parent d63cb62 commit 1d99de8

13 files changed

Lines changed: 113 additions & 484 deletions

Src/IronPython/IronPython.ruleset renamed to IronPython.ruleset

Lines changed: 60 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<IncludeAll Action="Warning" />
44
<Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
55
<Rule Id="CA1000" Action="None" />
6-
<Rule Id="CA1001" Action="Error" />
6+
<Rule Id="CA1001" Action="None" />
77
<Rule Id="CA1002" Action="None" />
88
<Rule Id="CA1003" Action="Error" />
99
<Rule Id="CA1004" Action="None" />
@@ -14,20 +14,20 @@
1414
<Rule Id="CA1009" Action="Error" />
1515
<Rule Id="CA1010" Action="None" />
1616
<Rule Id="CA1011" Action="None" />
17-
<Rule Id="CA1012" Action="Error" />
17+
<Rule Id="CA1012" Action="None" />
1818
<Rule Id="CA1013" Action="None" />
19-
<Rule Id="CA1014" Action="Error" />
19+
<Rule Id="CA1014" Action="None" />
2020
<Rule Id="CA1016" Action="Error" />
2121
<Rule Id="CA1017" Action="Error" />
22-
<Rule Id="CA1018" Action="Error" />
23-
<Rule Id="CA1019" Action="Error" />
22+
<Rule Id="CA1018" Action="None" />
23+
<Rule Id="CA1019" Action="None" />
2424
<Rule Id="CA1020" Action="None" />
2525
<Rule Id="CA1021" Action="None" />
2626
<Rule Id="CA1023" Action="None" />
2727
<Rule Id="CA1024" Action="None" />
2828
<Rule Id="CA1025" Action="Error" />
2929
<Rule Id="CA1026" Action="None" />
30-
<Rule Id="CA1027" Action="Error" />
30+
<Rule Id="CA1027" Action="None" />
3131
<Rule Id="CA1028" Action="Error" />
3232
<Rule Id="CA1030" Action="None" />
3333
<Rule Id="CA1031" Action="None" />
@@ -49,20 +49,20 @@
4949
<Rule Id="CA1049" Action="Error" />
5050
<Rule Id="CA1050" Action="Error" />
5151
<Rule Id="CA1051" Action="None" />
52-
<Rule Id="CA1052" Action="Error" />
52+
<Rule Id="CA1052" Action="None" />
5353
<Rule Id="CA1053" Action="None" />
5454
<Rule Id="CA1054" Action="Error" />
5555
<Rule Id="CA1055" Action="Error" />
5656
<Rule Id="CA1056" Action="Error" />
5757
<Rule Id="CA1057" Action="Error" />
5858
<Rule Id="CA1058" Action="Error" />
5959
<Rule Id="CA1059" Action="Error" />
60-
<Rule Id="CA1060" Action="Error" />
60+
<Rule Id="CA1060" Action="None" />
6161
<Rule Id="CA1061" Action="None" />
6262
<Rule Id="CA1062" Action="None" />
6363
<Rule Id="CA1063" Action="None" />
6464
<Rule Id="CA1064" Action="None" />
65-
<Rule Id="CA1065" Action="Error" />
65+
<Rule Id="CA1065" Action="None" />
6666
<Rule Id="CA1300" Action="None" />
6767
<Rule Id="CA1301" Action="None" />
6868
<Rule Id="CA1302" Action="None" />
@@ -122,22 +122,22 @@
122122
<Rule Id="CA1726" Action="None" />
123123
<Rule Id="CA1800" Action="None" />
124124
<Rule Id="CA1801" Action="None" />
125-
<Rule Id="CA1802" Action="Error" />
125+
<Rule Id="CA1802" Action="None" />
126126
<Rule Id="CA1804" Action="Error" />
127-
<Rule Id="CA1806" Action="Error" />
127+
<Rule Id="CA1806" Action="None" />
128128
<Rule Id="CA1809" Action="Error" />
129-
<Rule Id="CA1810" Action="Error" />
129+
<Rule Id="CA1810" Action="None" />
130130
<Rule Id="CA1811" Action="Error" />
131-
<Rule Id="CA1812" Action="Error" />
132-
<Rule Id="CA1813" Action="Error" />
131+
<Rule Id="CA1812" Action="None" />
132+
<Rule Id="CA1813" Action="None" />
133133
<Rule Id="CA1814" Action="None" />
134134
<Rule Id="CA1815" Action="None" />
135135
<Rule Id="CA1816" Action="None" />
136136
<Rule Id="CA1819" Action="Error" />
137-
<Rule Id="CA1820" Action="Error" />
137+
<Rule Id="CA1820" Action="None" />
138138
<Rule Id="CA1821" Action="Error" />
139-
<Rule Id="CA1822" Action="Error" />
140-
<Rule Id="CA1823" Action="Error" />
139+
<Rule Id="CA1822" Action="None" />
140+
<Rule Id="CA1823" Action="None" />
141141
<Rule Id="CA1824" Action="Error" />
142142
<Rule Id="CA1900" Action="Error" />
143143
<Rule Id="CA1901" Action="Error" />
@@ -177,29 +177,29 @@
177177
<Rule Id="CA2142" Action="None" />
178178
<Rule Id="CA2147" Action="Error" />
179179
<Rule Id="CA2149" Action="None" />
180-
<Rule Id="CA2200" Action="Error" />
180+
<Rule Id="CA2200" Action="None" />
181181
<Rule Id="CA2201" Action="None" />
182182
<Rule Id="CA2204" Action="None" />
183183
<Rule Id="CA2205" Action="Error" />
184184
<Rule Id="CA2207" Action="Error" />
185-
<Rule Id="CA2208" Action="Error" />
185+
<Rule Id="CA2208" Action="None" />
186186
<Rule Id="CA2210" Action="None" />
187187
<Rule Id="CA2211" Action="None" />
188188
<Rule Id="CA2212" Action="Error" />
189189
<Rule Id="CA2213" Action="Error" />
190-
<Rule Id="CA2214" Action="Error" />
190+
<Rule Id="CA2214" Action="None" />
191191
<Rule Id="CA2216" Action="Error" />
192192
<Rule Id="CA2217" Action="Error" />
193193
<Rule Id="CA2218" Action="Error" />
194-
<Rule Id="CA2219" Action="Error" />
194+
<Rule Id="CA2219" Action="None" />
195195
<Rule Id="CA2220" Action="Error" />
196196
<Rule Id="CA2221" Action="Error" />
197197
<Rule Id="CA2222" Action="Error" />
198198
<Rule Id="CA2223" Action="Error" />
199199
<Rule Id="CA2224" Action="Error" />
200200
<Rule Id="CA2225" Action="None" />
201201
<Rule Id="CA2226" Action="Error" />
202-
<Rule Id="CA2227" Action="Error" />
202+
<Rule Id="CA2227" Action="None" />
203203
<Rule Id="CA2228" Action="Error" />
204204
<Rule Id="CA2229" Action="Error" />
205205
<Rule Id="CA2230" Action="Error" />
@@ -216,4 +216,42 @@
216216
<Rule Id="CA2242" Action="Error" />
217217
<Rule Id="CA2243" Action="Error" />
218218
</Rules>
219+
<Rules AnalyzerId="Microsoft.CodeQuality.CSharp.Analyzers" RuleNamespace="Microsoft.CodeQuality.CSharp.Analyzers">
220+
<Rule Id="CA1065" Action="None" />
221+
<Rule Id="CA1507" Action="None" />
222+
<Rule Id="CA1001" Action="None" />
223+
<Rule Id="CA1200" Action="None" />
224+
<Rule Id="CA1019" Action="None" />
225+
<Rule Id="CA2200" Action="None" />
226+
</Rules>
227+
<Rules AnalyzerId="Microsoft.NetCore.CSharp.Analyzers" RuleNamespace="Microsoft.NetCore.CSharp.Analyzers">
228+
<Rule Id="CA1825" Action="None" />
229+
<Rule Id="CA1810" Action="None" />
230+
<Rule Id="CA5351" Action="None" />
231+
<Rule Id="CA5350" Action="None" />
232+
</Rules>
233+
<Rules AnalyzerId="Microsoft.CodeQuality.Analyzers" RuleNamespace="Microsoft.CodeQuality.Analyzers">
234+
<Rule Id="CA2227" Action="None" />
235+
<Rule Id="CA1822" Action="None" />
236+
<Rule Id="CA1823" Action="None" />
237+
<Rule Id="CA1018" Action="None" />
238+
<Rule Id="CA1052" Action="None" />
239+
<Rule Id="CA1802" Action="None" />
240+
<Rule Id="CA1027" Action="None" />
241+
<Rule Id="CA1060" Action="None" />
242+
<Rule Id="CA2214" Action="None" />
243+
<Rule Id="CA1012" Action="None" />
244+
<Rule Id="CA1806" Action="None" />
245+
<Rule Id="CA1812" Action="None" />
246+
<Rule Id="CA1014" Action="None" />
247+
<Rule Id="CA2219" Action="None" />
248+
</Rules>
249+
<Rules AnalyzerId="Microsoft.NetCore.Analyzers" RuleNamespace="Microsoft.NetCore.Analyzers">
250+
<Rule Id="CA1820" Action="None" />
251+
<Rule Id="CA1813" Action="None" />
252+
<Rule Id="CA2208" Action="None" />
253+
</Rules>
254+
<Rules AnalyzerId="Microsoft.NetFramework.Analyzers" RuleNamespace="Microsoft.NetFramework.Analyzers">
255+
<Rule Id="CA3075" Action="None" />
256+
</Rules>
219257
</RuleSet>

‎Src/IronPython.Modules/IronPython.Modules.csproj‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<TargetFrameworks>net45;netcoreapp2.0;netcoreapp2.1;netstandard2.0</TargetFrameworks>
55
<BaseAddress>885063680</BaseAddress>
6-
<CodeAnalysisRuleSet>$(AssemblyName).ruleset</CodeAnalysisRuleSet>
6+
<CodeAnalysisRuleSet>..\..\IronPython.ruleset</CodeAnalysisRuleSet>
77
<DocumentationFile>$(OutputPath)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
88
</PropertyGroup>
99

@@ -22,7 +22,10 @@
2222
</ItemGroup>
2323

2424
<ItemGroup>
25-
<None Include="IronPython.Modules.ruleset" />
25+
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.3">
26+
<PrivateAssets>all</PrivateAssets>
27+
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
28+
</PackageReference>
2629
</ItemGroup>
2730

2831
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' OR '$(TargetFramework)' == 'netcoreapp2.1' OR '$(TargetFramework)' == 'netstandard2.0' ">

0 commit comments

Comments
 (0)