Server Implementation
Paper
Server Version
1.20.4
Describe the bug
When clearing a plot in an area utilizing plot schematics, the schematic will be pasted one block too low.
World-Generation itself works (e.g. //regen works).
The culprit seems to be somewhere here (used by the FAWE Delegate to determine minY for plot schematics):
|
public int getPlotYStart() { |
|
return SCHEM_Y + plotY; |
|
} |
When replacing SCHEM_Y + plotY with getMinBuildHeight() (the same reference point the world generator uses, as visible in HybridGen: https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/generator/HybridGen.java#L76) clear works. My only idea for that being is, that one of these two variables is normalized somewhere - possibly against the road height.
I don't just want to PR my fix, as I'm not sure what the reasoning behind the change was (@dordsor21 ?) and if that does not have any unexpected side effects.
To Reproduce
- Create plot schematic as described in wiki (
/plot schematic save, move to appropriate schematic folder)
- World will be generated accordingly
- Claim Plot and run
/plot clear
- Schematic will be one block too low
Expected behaviour
The schematic should be pasted from the correct y-level
Screenshots / Videos
No response
Error log (if applicable)
No response
Fawe Debugpaste
Fawe Version
Checklist
Anything else?
No response
Server Implementation
Paper
Server Version
1.20.4
Describe the bug
When clearing a plot in an area utilizing plot schematics, the schematic will be pasted one block too low.
World-Generation itself works (e.g. //regen works).
The culprit seems to be somewhere here (used by the FAWE Delegate to determine minY for plot schematics):
PlotSquared/Core/src/main/java/com/plotsquared/core/generator/HybridPlotWorld.java
Lines 558 to 560 in a641258
When replacing
SCHEM_Y + plotYwithgetMinBuildHeight()(the same reference point the world generator uses, as visible in HybridGen: https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/generator/HybridGen.java#L76) clear works. My only idea for that being is, that one of these two variables is normalized somewhere - possibly against the road height.I don't just want to PR my fix, as I'm not sure what the reasoning behind the change was (@dordsor21 ?) and if that does not have any unexpected side effects.
To Reproduce
/plot schematic save, move to appropriate schematic folder)/plot clearExpected behaviour
The schematic should be pasted from the correct y-level
Screenshots / Videos
No response
Error log (if applicable)
No response
Fawe Debugpaste
Fawe Version
Checklist
Anything else?
No response