Skip to content

Commit 9fa5123

Browse files
fix: use appendChild instead of insertBefore for theme styles to ensure correct CSS cascade order
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular-samples/sessions/b7433c38-919d-4392-a94a-cb4ae0dbede8 Co-authored-by: viktorkombov <75325639+viktorkombov@users.noreply.github.com>
1 parent 3197a57 commit 9fa5123

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

projects/app-lob/src/app/app.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ export class AppComponent implements OnInit {
6262
typefaceElem.rel = 'stylesheet';
6363
typefaceElem.id = 'ignteui-theme-typeface';
6464
typefaceElem.href = this.typefaceUrl + typeface.split(' ').join('+');
65-
this.document.head.insertBefore(typefaceElem, this.document.head.lastElementChild);
65+
this.document.head.appendChild(typefaceElem);
6666
}
6767

6868
private createThemeStyle() {
6969
this.styleElem = this.document.createElement('style');
7070
this.styleElem.id = 'igniteui-theme';
71-
this.document.head.insertBefore(this.styleElem, this.document.head.lastElementChild);
71+
this.document.head.appendChild(this.styleElem);
7272
this.document.body.classList.add('custom-body');
7373
}
7474
}

projects/app-lob/src/app/index/docs-layout.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class DocsLayoutComponent implements OnInit {
4242
private createThemeStyle() {
4343
this.styleElem = this.document.createElement('style');
4444
this.styleElem.id = 'igniteui-theme';
45-
this.document.head.insertBefore(this.styleElem, this.document.head.lastElementChild);
45+
this.document.head.appendChild(this.styleElem);
4646
this.document.body.classList.add('custom-body');
4747
}
4848

@@ -51,6 +51,6 @@ export class DocsLayoutComponent implements OnInit {
5151
typefaceElem.rel = 'stylesheet';
5252
typefaceElem.id = 'ignteui-theme-typeface';
5353
typefaceElem.href = this.typefaceUrl + typeface.split(' ').join('+');
54-
this.document.head.insertBefore(typefaceElem, this.document.head.lastElementChild);
54+
this.document.head.appendChild(typefaceElem);
5555
}
5656
}

src/app/app.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@ export class AppComponent implements OnInit {
4444
typefaceElem.rel = 'stylesheet';
4545
typefaceElem.id = 'ignteui-theme-typeface';
4646
typefaceElem.href = this.typefaceUrl + typeface.split(' ').join('+');
47-
this.document.head.insertBefore(typefaceElem, this.document.head.lastElementChild);
47+
this.document.head.appendChild(typefaceElem);
4848
}
4949

5050
private createThemeStyle() {
5151
this.styleElem = this.document.createElement('style');
5252
this.styleElem.id = 'igniteui-theme';
53-
this.document.head.insertBefore(this.styleElem, this.document.head.lastElementChild);
53+
this.document.head.appendChild(this.styleElem);
5454
this.document.body.classList.add('custom-body');
5555
}
5656
}

0 commit comments

Comments
 (0)