code style

rbri · rbri · commit c2e35f828ded · 2025-09-06T15:28:32.000+02:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.17.0" date="September xx, 2025" description="Chrome/Edge 140, Firefox 142, Bugfixes">
+            <action type="fix" dev="René Schwietzke" issue="#1014">
+                Properly synchronize access to httpClientBuilder_ in class HttpWebConnection.
+            </action>
             <action type="fix" dev="RhinoTeam">
                 core-js: fix erro stack generation in interpreted mode and report the correct line number
             </action>
diff --git a/src/main/java/org/htmlunit/HttpWebConnection.java b/src/main/java/org/htmlunit/HttpWebConnection.java
@@ -533,25 +533,25 @@ private static HttpRequestBase buildHttpMethod(final HttpMethod submitMethod, fi
      * @return the initialized HTTP client
      */
     protected HttpClientBuilder getHttpClientBuilder() {
-        synchronized (httpClientBuilder_)
-        {
-            final Thread currentThread = Thread.currentThread();
+        final Thread currentThread = Thread.currentThread();
+
+        synchronized (httpClientBuilder_) {
             HttpClientBuilder builder = httpClientBuilder_.get(currentThread);
             if (builder == null) {
                 builder = createHttpClientBuilder();
-    
+
                 // this factory is required later
                 // to be sure this is done, we do it outside the createHttpClient() call
                 final RegistryBuilder<CookieSpecProvider> registeryBuilder
                     = RegistryBuilder.<CookieSpecProvider>create()
                                 .register(HACKED_COOKIE_POLICY, htmlUnitCookieSpecProvider_);
                 builder.setDefaultCookieSpecRegistry(registeryBuilder.build());
-    
+
                 builder.setDefaultCookieStore(new HtmlUnitCookieStore(webClient_.getCookieManager()));
                 builder.setUserAgent(webClient_.getBrowserVersion().getUserAgent());
                 httpClientBuilder_.put(currentThread, builder);
             }
-    
+
             return builder;
         }
     }
