Skip to content

Commit f390275

Browse files
authored
Fix update of scoop package installed using manifest url (#4594)
1 parent 23de520 commit f390275

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgDetailsHelper.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,11 @@ protected override void GetDetails_UnSafe(IPackageDetails details)
4242
}
4343

4444
string packageId;
45-
// If source is ellpised or source is a local path, omit source argument
45+
// If source is ellipsed, a local path, or a URL manifest, omit source argument
4646
if (
4747
details.Package.Source.Name.Contains("...")
4848
|| details.Package.Source.Name.Contains(":\\")
49+
|| details.Package.Source.Name.StartsWith("http")
4950
)
5051
packageId = $"{details.Package.Id}";
5152
else

src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgOperationHelper.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ OperationType operation
2828
},
2929
];
3030

31-
// If source is ellpised or source is a local path, omit source argument
32-
if (package.Source.Name.Contains("...") || package.Source.Name.Contains(":\\"))
31+
// If source is ellipsed, a local path, or a URL manifest, omit source argument
32+
if (package.Source.Name.Contains("...") || package.Source.Name.Contains(":\\") || package.Source.Name.StartsWith("http"))
3333
parameters.Add($"{package.Id}");
3434
else
3535
parameters.Add($"{package.Source.Name}/{package.Id}");

0 commit comments

Comments
 (0)