refactor: use query array for endpoint params (#130)

Author: alfonsobries

src/API/Node.php

@@ -49,12 +49,12 @@ public function crypto(): ?array
     /**
      * Get the node fee statistics.
      *
-     * @param int|null $days
+     * @param array $query
      *
      * @return array
      */
-    public function fees(?int $days = null): ?array
+    public function fees(array $query = []): ?array
     {
-        return $this->requestGet('node/fees', ['days' => $days]);
+        return $this->requestGet('node/fees', $query);
     }
 }

src/API/Transactions.php

@@ -45,11 +45,13 @@ public function get(string $id): ?array
     /**
      * Get all unconfirmed transactions.
      *
+     * @param array $query
+     *
      * @return array
      */
-    public function allUnconfirmed(): ?array
+    public function allUnconfirmed(array $query = []): ?array
     {
-        return $this->withApi('transactions')->requestGet('transactions/unconfirmed');
+        return $this->withApi('transactions')->requestGet('transactions/unconfirmed', $query);
     }
 
     /**

src/API/Wallets.php

@@ -85,11 +85,13 @@ public function votes(string $id, array $query = []): ?array
     /**
      * Get all wallets sorted by balance in descending order.
      *
+     * @param array $query
+     *
      * @return array
      */
-    public function top(): ?array
+    public function top(array $query = []): ?array
     {
-        return $this->requestGet('wallets/top');
+        return $this->requestGet('wallets/top', $query);
     }
 
     /**

tests/API/NodeTest.php

@@ -38,6 +38,6 @@
 
 it('calls the correct url for fees with query', function () {
     $this->assertResponse('GET', 'node/fees?days=7', function (Client $client) {
-        return $client->node()->fees(7);
+        return $client->node()->fees(['days' => 7]);
     });
 });

tests/API/TransactionsTest.php

@@ -40,6 +40,17 @@
     );
 });
 
+it('calls correct url for all unconfirmed with query', function () {
+    $this->assertResponse(
+        method: 'GET',
+        path: 'transactions/unconfirmed?limit=50',
+        callback: function (Client $client) {
+            return $client->transactions()->allUnconfirmed(['limit' => 50]);
+        },
+        expectedApi: 'transactions'
+    );
+});
+
 it('calls correct url for get unconfirmed', function () {
     $this->assertResponse(
         method: 'GET',

tests/API/WalletsTest.php

@@ -18,6 +18,12 @@
     });
 });
 
+it('calls correct url for top with query', function () {
+    $this->assertResponse('GET', 'wallets/top?limit=10', function (Client $client) {
+        return $client->wallets()->top(['limit' => 10]);
+    });
+});
+
 it('calls correct url for get', function () {
     $this->assertResponse('GET', 'wallets/dummy', function (Client $client) {
         return $client->wallets()->get('dummy');